[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Integrated: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
From:       Aleksey Shipilev <shade () openjdk ! org>
Date:       2023-07-25 8:48:52
Message-ID: kyyZX73NGsNUQHizEUfcPYp8d45uTc1PzUFifvHe8ks=.3605341c-4da7-4cd0-901b-34d508644944 () github ! com
[Download RAW message or body]

On Mon, 24 Jul 2023 10:37:43 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> At least GCC 6 fail the build with warnings-as-errors here:
> 
> 
> ../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc: In function 'void \
>                 _collect_layout_variation_indices(hb_subset_plan_t*)':
> ../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc:389:83: error: \
> suggest parentheses around assignment used as truth value [-Werror=parentheses] if \
> (unlikely (!plan->check_success (font = _get_hb_font_with_variations (plan)))) { ^
> ../src/java.desktop/share/native/libharfbuzz/hb.hh:259:46: note: in definition of \
> macro 'unlikely' #define unlikely(expr) (__builtin_expect (!!(expr), 0))
> ^~~~
> 
> 
> This is caused by HarfBuzz update to 7.2.0, \
> [JDK-8307301](https://bugs.openjdk.org/browse/JDK-8307301) 
> Instead of fixing the HarfBuzz sources in-tree, it is cleaner to disable the \
> warning. Lots of follow-ups after this HarfBuzz update did the same. 
> Additional testing:
> - [x] Linux x86_64 fastdebug build on affected systems

This pull request has now been integrated.

Changeset: ea067fc3
Author:    Aleksey Shipilev <shade@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ea067fc3d2b1fecda694442c7921ecb980377c1e
                
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8312592: New parentheses warnings after HarfBuzz 7.2.0 update

Reviewed-by: prr, serb

-------------

PR: https://git.openjdk.org/jdk/pull/14996


[prev in list] [next in list] [prev in thread] [next in thread]