[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
From:       Aleksey Shipilev <shade () openjdk ! org>
Date:       2023-07-25 8:48:51
Message-ID: JSfevBQ1l-Ij0AMsledJzNUEDbreCdHwNVVtiuJMOEU=.fbe51c14-d5c1-4430-af27-51eed8cd0e90 () github ! com
[Download RAW message or body]

On Mon, 24 Jul 2023 10:37:43 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> At least GCC 6 fail the build with warnings-as-errors here:
> 
> 
> ../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc: In function 'void \
>                 _collect_layout_variation_indices(hb_subset_plan_t*)':
> ../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc:389:83: error: \
> suggest parentheses around assignment used as truth value [-Werror=parentheses] if \
> (unlikely (!plan->check_success (font = _get_hb_font_with_variations (plan)))) { ^
> ../src/java.desktop/share/native/libharfbuzz/hb.hh:259:46: note: in definition of \
> macro 'unlikely' #define unlikely(expr) (__builtin_expect (!!(expr), 0))
> ^~~~
> 
> 
> This is caused by HarfBuzz update to 7.2.0, \
> [JDK-8307301](https://bugs.openjdk.org/browse/JDK-8307301) 
> Instead of fixing the HarfBuzz sources in-tree, it is cleaner to disable the \
> warning. Lots of follow-ups after this HarfBuzz update did the same. 
> Additional testing:
> - [x] Linux x86_64 fastdebug build on affected systems

Thanks for reviews! I am integrating to unblock some GCC 6 pipelines.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14996#issuecomment-1649393465


[prev in list] [next in list] [prev in thread] [next in thread]