[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8283404: [macos] a11y : Screen magnifier does not show JMenu name [v2]
From:       Sergey Bylokhov <serb () openjdk ! org>
Date:       2023-03-31 20:05:17
Message-ID: AmnvtHx3fGBIjWgWhK2Gmt0fvcVsl8qVleapgG-q0_k=.d9bfe91b-1b47-4e6a-9f2d-d39625aacc40 () github ! com
[Download RAW message or body]

On Fri, 31 Mar 2023 17:08:19 GMT, Abhishek Kumar <abhiscxk@openjdk.org> wrote:

> > It seems that the accessibility role returned by the MenuAccessibility class is \
> > not correct for top level menu. 
> > Added a condition check to return the accessibility role as \
> > `NSAccessibilityMenuBarItemRole` in stead of `NSAccessibilityMenuRole` for top \
> > level menu whose parent is `menubar`.  
> > The solution works correctly for screen magnifier as well as voice over. 
> > 
> > A manual test case is added to verify the fix.
> > 
> > Note: Tried implementing few a11y methods to fix but for top level menu with \
> > `NSAccessibilityMenuRole` doesn't return the a11y label.
> 
> Abhishek Kumar has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Test instruction update

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13271#pullrequestreview-1367526608


[prev in list] [next in list] [prev in thread] [next in thread]