[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8305352: updateIconImages may lead to deadlock after JDK-8276849
From:       Phil Race <prr () openjdk ! org>
Date:       2023-03-31 19:10:14
Message-ID: C0Nc-miZwXIt2kyZyXcxzuIzbAG8tuXh6D5rtAmvqEw=.60af033b-4d64-4cd3-8fe5-ea95c9dc6f60 () github ! com
[Download RAW message or body]

On Fri, 31 Mar 2023 09:11:20 GMT, Dmitry Cherepanov <dcherepanov@openjdk.org> wrote:

> Please review this PR which suggests to skip updateIconImages() for not yet visible \
> windows. The displayChanged notification can be sent to a window that is in the \
> process of initiailization and calling updateIconImages() may lead to the deadlock. \
>                 
> Testing: the deadlock no longer happens with this patch. The reg test for \
> JDK-8276849 works (window icon is updated after changing DPI settings).

> It seems that the root cause is a cyclic dependency between GraphicsPrimitiveMgr \
> and Blit during static initialization

Yes, and there was a bug on this a long time ago, but for bureaucratic reasons it got \
closed. It ought to be re-opened : https://bugs.openjdk.org/browse/JDK-6995195

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13263#issuecomment-1492462572


[prev in list] [next in list] [prev in thread] [next in thread]