[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Integrated: 8302558: Editable JComboBox's popup blocks user from seeing characters in Aqua look and 
From:       Damon Nguyen <dnguyen () openjdk ! org>
Date:       2023-03-27 19:07:48
Message-ID: fhZ8SjvKck_Y6ADEVWRiiTsv62MFmTIJ19-zKqQmVZo=.3b5c658f-5a6e-46d0-92b0-02ed4e1349ef () github ! com
[Download RAW message or body]

On Fri, 24 Feb 2023 21:54:30 GMT, Damon Nguyen <dnguyen@openjdk.org> wrote:

> The issue is in Aqua L&F when an editable JComboBox with a border is used. In this \
> case, when the comboBox is clicked for the drop-down menu to show, the drop-down \
> menu appears at the wrong coordinates (blocking the text of the comboBox and making \
> it unreadable). 
> This seems to have been the case for a while and a similar issue appeared recently \
> where an editable Aqua JComboBox also had wrong positioning due to having a border. \
>  This fix checks for a border and modifies the bounds to accommodate the border's \
> size. Then the usual calculations for the comboBox popup works as expected. 
> The new headful test creates an editable comboBox with a TitledBorder and with no \
> border. Then, it automatically clicks the comboBox to open the popup, and clicks \
> where the position of the first selectionItem should be. Finally, it checks if the \
> selected item is correct. This is for all L&F's and the test passes on all OS's.

This pull request has now been integrated.

Changeset: 80e2d52f
Author:    Damon Nguyen <dnguyen@openjdk.org>
Committer: Alexander Zvegintsev <azvegint@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/80e2d52f76806bc886138a0fd4c34b1ca3dc4c0b
                
Stats:     227 lines in 2 files changed: 225 ins; 0 del; 2 mod

8302558: Editable JComboBox's popup blocks user from seeing characters in Aqua look \
and feel

Reviewed-by: psadhukhan, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/12750


[prev in list] [next in list] [prev in thread] [next in thread]