[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and fee
From:       Alexander Zvegintsev <azvegint () openjdk ! org>
Date:       2023-03-27 17:28:44
Message-ID: FYBKnrUWexEF2NuwYbRpfmJ5QfBADWEJw7H_OEyfX-4=.f142c17a-5e60-4415-8dde-3cc92ddbf556 () github ! com
[Download RAW message or body]

On Mon, 27 Mar 2023 17:12:51 GMT, Damon Nguyen <dnguyen@openjdk.org> wrote:

> > The issue is in Aqua L&F when an editable JComboBox with a border is used. In \
> > this case, when the comboBox is clicked for the drop-down menu to show, the \
> > drop-down menu appears at the wrong coordinates (blocking the text of the \
> > comboBox and making it unreadable). 
> > This seems to have been the case for a while and a similar issue appeared \
> > recently where an editable Aqua JComboBox also had wrong positioning due to \
> > having a border. 
> > This fix checks for a border and modifies the bounds to accommodate the border's \
> > size. Then the usual calculations for the comboBox popup works as expected. 
> > The new headful test creates an editable comboBox with a TitledBorder and with no \
> > border. Then, it automatically clicks the comboBox to open the popup, and clicks \
> > where the position of the first selectionItem should be. Finally, it checks if \
> > the selected item is correct. This is for all L&F's and the test passes on all \
> > OS's.
> 
> Damon Nguyen has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Add null check for frame

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/12750#pullrequestreview-1359552321


[prev in list] [next in list] [prev in thread] [next in thread]