[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines [v2]
From:       Manukumar V S <mvs () openjdk ! org>
Date:       2022-06-29 6:53:30
Message-ID: Yr1gnb4-3V_qnfHg6ZMspi2teENcgX9JolgJHgV4WgI=.f9dfd53a-ec07-42f6-b9fd-17f11f209e88 () github ! com
[Download RAW message or body]

On Wed, 29 Jun 2022 00:53:08 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> > Manukumar V S has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > Review comments fixed: Removed -Dsun.java2d.uiScale=1, \
> > frame.getLocationOnScreen() removed from EDT, added volatile keyword for \
> > actionEventReceivedLatch
> 
> test/jdk/java/awt/PopupMenu/PopupMenuLocation.java line 69:
> 
> > 67:             GraphicsConfiguration gc = sd.getDefaultConfiguration();
> > 68:             Rectangle bounds = gc.getBounds();
> > 69:             Point point = new Point(bounds.x + 20, bounds.y + 20);
> 
> Why do you need to add this additional 20 pixels? When we click on the frame we \
> already shift the mouse click location by 130 pixels from the top of the frame.

Reverted it

> test/jdk/java/awt/PopupMenu/PopupMenuLocation.java line 119:
> 
> > 117:     private static void openPopup(final Frame frame) throws Exception {
> > 118:         robot.waitForIdle();
> > 119:         Point loc = frame.getLocationOnScreen();
> 
> Since you removed the reading the location from EDT via a separate loc variable, \
> you do not need to rename pt here? The only meaningful change is adding the \
> CountDownLatch?

Reverted it

-------------

PR: https://git.openjdk.org/jdk/pull/9187


[prev in list] [next in list] [prev in thread] [next in thread]