[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails [v2]
From:       Sergey Bylokhov <serb () openjdk ! java ! net>
Date:       2021-10-30 1:24:06
Message-ID: i6dOBryh--xu_Dz_Kts5iSOQZft1qqhCr-uSJcZwvcE=.cbbcac62-3b66-4480-a15c-80d4a4698bca () github ! com
[Download RAW message or body]

On Fri, 29 Oct 2021 09:24:29 GMT, Alexander Zuev <kizune@openjdk.org> wrote:

> > The problem here is that due to the approximation of the coordinates when \
> > converting to and from screen cordinate system on screen with 125% magnification 
> > two things can happen:
> > 1. New mouse position calculated can be 149/149 which is the same as the starting \
> > position and system can refuse to generate new mouse event which causes false \
> > positive of the test since second mouse motion listener was never called;
> > 2. Even if event is generated the resulting reported coordinates can differ by 1 \
> > pixel in any of the directions;
> > 
> > To solve it i moved away the target point to make sure that move event always \
> > generated and comparing expected and actual coordinates with approximation of +/- \
> > 1 pixel.
> 
> Alexander Zuev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Protect from second mouse move image invocation.

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/6128


[prev in list] [next in list] [prev in thread] [next in thread]