[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8159451: [TEST_BUG] java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java
From:       Phil Race <prr () openjdk ! java ! net>
Date:       2021-10-29 21:33:14
Message-ID: ExePjnN8Y5CtQhQeAG7v_cJWbB9cOfkfJdpBZeR0K_c=.15aa272b-d54d-41f6-a5ac-48c7f9063409 () github ! com
[Download RAW message or body]

On Fri, 29 Oct 2021 19:54:47 GMT, Alisen Chung <duke@openjdk.java.net> wrote:

> Added more time to test, removed pixel check during EmbeddedFrame test from OverlappingTestBase.

The bug says
This test just need more time to go. 
Provided JDK-8158801 is fixed. 

but that bug isn't fixed ..

test/jdk/java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java line 145:

> 143:         }
> 144: 
> 145:         if(currentAwtControl == null) { System.out.println("t"); }

Is this a left over debugging statement ?

test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 359:

> 357:     private static boolean isValidForPixelCheck(Component component) {
> 358:         if ((component instanceof java.awt.Scrollbar)
> 359:                 || (isMac && ((component instanceof java.awt.Button) || (component == null)))) {

"removed pixel check during EmbeddedFrame test from OverlappingTestBase."

Well you presumably can't pixel check a null component, but why is it null ?
It seems like a test issue for it to be null. Can you explain how this happens ?

Also if this code *were* to stay it would be better formatted like
 if ((component instanceof java.awt.Scrollbar) ||
      (isMac && ((component instanceof java.awt.Button) ||
      (component == null))))
 {

-------------

PR: https://git.openjdk.java.net/jdk/pull/6177
[prev in list] [next in list] [prev in thread] [next in thread]