[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8241829 Cleanup the code for PrinterJob on windows
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2020-03-31 22:21:45
Message-ID: 39bb33da-692e-20a6-07b8-7cf628a9a5a9 () oracle ! com
[Download RAW message or body]

Hi, Prasanta.

On 3/30/20 7:46 am, Prasanta Sadhukhan wrote:
> I guess it is better if you directly pass NULL to OpenPrinter, rather than create \
> an unnecessary variable.

That was done only for documentation purposes.

> Also, I think it will be good if we do a ClosePrinter() if \
> FindFirstPrinterChangeNotification() fails.

Nice catch! webrev is updated:
http://cr.openjdk.java.net/~serb/8241829/webrev.01

> 
> Regards
> Prasanta
> On 30-Mar-20 7:13 PM, Sergey Bylokhov wrote:
> > Hello.
> > Please review the fix for jdk/client.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8241829
> > Fix: http://cr.openjdk.java.net/~serb/8241829/webrev.00
> > 
> > In PrintServiceLookupProvider.java we always pass NULL to
> > the notifyFirstPrinterChange as a name of the printer, so
> > we can remove the code which expects a non-null value.
> > 


-- 
Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]