[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [11u] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality
From: "Baesken, Matthias" <matthias.baesken () sap ! com>
Date: 2019-10-01 8:18:57
Message-ID: AM6PR02MB507877A315677208C81C7D81939D0 () AM6PR02MB5078 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
Hi Christoph, looks good to me .
I think the naming "xinerama_init_linux" is a bit misleading now , because the \
function is obviously not any more just for linux :
619 #if defined(__linux__) || defined(MACOSX) || defined(_AIX)
620 static void xinerama_init_linux()
But this is out of scope of your downport change .
Best regards, Matthias
From: Langer, Christoph
Sent: Dienstag, 24. September 2019 15:39
To: jdk-updates-dev@openjdk.java.net<mailto:jdk-updates-dev@openjdk.java.net>
Cc: 2d-dev@openjdk.java.net<mailto:2d-dev@openjdk.java.net>
Subject: [11u] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality
Hi,
please help reviewing this backport of the fix for AIX Xinerama/Xrender basic \
functionality to JDK11 Updates.
Bug: https://bugs.openjdk.java.net/browse/JDK-8220528
Original Change: http://hg.openjdk.java.net/jdk/jdk/rev/0223b7b8a1c5
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8220528.11u-dev.0/
The patch did not apply cleanly. I had to manually resolve the part around line 125 \
because the 11u version defines another function for Solaris that didn't exist any \
more in the head version. Furthermore I needed to fix the #ifdef in line 1641 (new) \
to explicitly refer Solaris. Otherwise it would not build on AIX.
Thanks
Christoph
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
span.changed
{mso-style-name:changed;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi Christoph, looks good to me \
.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US">I \
think the naming "</span><span lang="EN-US" \
style="font-size:10.0pt;font-family:"Courier \
New";color:black;mso-fareast-language:DE">xinerama_init_linux" is a \
bit misleading now , because the function is obviously not any more just for \
linux :</span><span lang="EN-US"><o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="font-size:10.0pt;font-family:"Courier \
New";color:blue;mso-fareast-language:DE">619 #if defined(__linux__) || \
defined(MACOSX) || defined(_AIX)</span><span lang="EN-US" \
style="font-size:10.0pt;font-family:"Courier \
New";color:black;mso-fareast-language:DE"><o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="font-size:10.0pt;font-family:"Courier \
New";color:black;mso-fareast-language:DE">620 static void \
xinerama_init_linux()<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US">But \
this is out of scope of your downport change .<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Best regards, Matthias<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <div \
style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" \
style="mso-fareast-language:DE">From:</span></b><span lang="EN-US" \
style="mso-fareast-language:DE"> Langer, Christoph <br>
<b>Sent:</b> Dienstag, 24. September 2019 15:39<br>
<b>To:</b> <a href="mailto:jdk-updates-dev@openjdk.java.net">jdk-updates-dev@openjdk.java.net</a><br>
<b>Cc:</b> <a href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a><br>
<b>Subject:</b> [11u] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender \
functionality<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">please help reviewing this backport of the \
fix for AIX Xinerama/Xrender basic functionality to JDK11 \
Updates.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8220528"> \
https://bugs.openjdk.java.net/browse/JDK-8220528</a><o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Original Change: <a \
href="http://hg.openjdk.java.net/jdk/jdk/rev/0223b7b8a1c5"> \
http://hg.openjdk.java.net/jdk/jdk/rev/0223b7b8a1c5</a><o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Webrev: <a \
href="http://cr.openjdk.java.net/~clanger/webrevs/8220528.11u-dev.0/"> \
http://cr.openjdk.java.net/~clanger/webrevs/8220528.11u-dev.0/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">The patch did not apply cleanly. I had to \
manually resolve the part around line 125 because the 11u version defines another \
function for Solaris that didn't exist any more in the head version. Furthermore I \
needed to fix the #ifdef in line 1641 (new) to explicitly refer Solaris. Otherwise \
it would not build on AIX.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Thanks<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Christoph</span><span lang="EN-US" \
style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#666666;mso-fareast-language:DE"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic