[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: [OpenJDK 2D-Dev] [11u] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality
From: "Langer, Christoph" <christoph.langer () sap ! com>
Date: 2019-09-24 13:39:28
Message-ID: AM6PR02MB5192C6AA802F55E8F960B87D8A840 () AM6PR02MB5192 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]
Hi,
please help reviewing this backport of the fix for AIX Xinerama/Xrender bas=
ic functionality to JDK11 Updates.
Bug: https://bugs.openjdk.java.net/browse/JDK-8220528
Original Change: http://hg.openjdk.java.net/jdk/jdk/rev/0223b7b8a1c5
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8220528.11u-dev.0/
The patch did not apply cleanly. I had to manually resolve the part around =
line 125 because the 11u version defines another function for Solaris that =
didn't exist any more in the head version. Furthermore I needed to fix the =
#ifdef in line 1641 (new) to explicitly refer Solaris. Otherwise it would n=
ot build on AIX.
Thanks
Christoph
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">please help reviewing this backport of the \
fix for AIX Xinerama/Xrender basic functionality to JDK11 \
Updates.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8220528"> \
https://bugs.openjdk.java.net/browse/JDK-8220528</a><o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Original Change: <a \
href="http://hg.openjdk.java.net/jdk/jdk/rev/0223b7b8a1c5"> \
http://hg.openjdk.java.net/jdk/jdk/rev/0223b7b8a1c5</a><o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Webrev: <a \
href="http://cr.openjdk.java.net/~clanger/webrevs/8220528.11u-dev.0/"> \
http://cr.openjdk.java.net/~clanger/webrevs/8220528.11u-dev.0/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">The patch did not apply cleanly. I had to \
manually resolve the part around line 125 because the 11u version defines another \
function for Solaris that didn’t exist any more in the head version. \
Furthermore I needed to fix the #ifdef in line 1641 (new) to explicitly refer \
Solaris. Otherwise it would not build on AIX.<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Thanks<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Christoph</span><span lang="EN-US" \
style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#666666;mso-fareast-language:DE"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic