[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR[14]: JDK-8230728 : Thin stroked shapes are not rendered if affine transform
From:       Laurent_Bourgès <bourges.laurent () gmail ! com>
Date:       2019-09-10 19:26:44
Message-ID: CAKjRUT72Uv_AQU0by8wi0OEzn9gJfzOmtX9WEO9v=pSEVLX2iA () mail ! gmail ! com
[Download RAW message or body]

Thanks,
I pushed: https://hg.openjdk.java.net/jdk/client/rev/7f55aad34ac4

Laurent

Le mar. 10 sept. 2019 Ã  07:47, Jayathirth Rao <jayathirth.d.v@oracle.com> a
écrit :

> +1.
>
> Thanks,
> Jay
>
> On 10-Sep-2019, at 3:18 AM, Phil Race <philip.race@oracle.com> wrote:
>
> Approved.
>
> -phil.
>
> On 9/6/19 2:15 PM, Laurent Bourgès wrote:
>
> Hi,
>
> Please review this bug fix for the Marlin renderer (present in Pisces code
> since JDK 6?):
> JBS: https://bugs.openjdk.java.net/browse/JDK-8230728
> webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/
>
> This patch fixes a NaN handling in userSpaceLineWidth() when the affine
> transform determinant is negative (flip bit is ON)
>
> Changes:
> - MarlinRenderingEngine: use abs(at.getDeterminant()) to ensure positive
> value before using sqrt
> - FlipBitTest: new jtreg test reproducing the original problem drawing a
> thin ellipse with a flipped transform
>
> Cheers,
> Laurent
>
>
>
>

-- 
-- 
Laurent Bourgès

[Attachment #3 (text/html)]

<div dir="ltr"><div>Thanks, <br></div><div>I pushed: <a \
href="https://hg.openjdk.java.net/jdk/client/rev/7f55aad34ac4">https://hg.openjdk.java \
.net/jdk/client/rev/7f55aad34ac4</a></div><div><br></div><div>Laurent<br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">Le  mar. 10 sept. 2019 Ã   \
07:47, Jayathirth Rao &lt;<a \
href="mailto:jayathirth.d.v@oracle.com">jayathirth.d.v@oracle.com</a>&gt; a écrit  \
:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
style="overflow-wrap: \
break-word;">+1.<div><br></div><div>Thanks,</div><div>Jay<br><div><div><br><blockquote \
type="cite"><div>On 10-Sep-2019, at 3:18 AM, Phil Race &lt;<a \
href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a>&gt; \
wrote:</div><br class="gmail-m_5322142676134144948Apple-interchange-newline"><div>  
    
  
  <div bgcolor="#FFFFFF">
    Approved.<br>
    <br>
    -phil.<br>
    <br>
    <div class="gmail-m_5322142676134144948moz-cite-prefix">On 9/6/19 2:15 PM, \
Laurent Bourgès  wrote:<br>
    </div>
    <blockquote type="cite">
      
      <div dir="ltr">
        <div>Hi,</div>
        <div><br>
        </div>
        <div>Please review this bug fix for the Marlin renderer (present
          in Pisces code since JDK 6?):</div>
        <div>JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8230728" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8230728</a></div>  \
<div>webrev: <a href="http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/" \
target="_blank">http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/</a></div>
  <div><br>
        </div>
        <div>This patch fixes a NaN handling in userSpaceLineWidth()
          when the affine transform determinant is negative (flip bit is
          ON)</div>
        <div><br>
        </div>
        <div>Changes:</div>
        <div>- MarlinR<span>enderingEngine: use
            abs(at.getDeterminant()) to ensure positive value before
            using sqrt</span></div>
        <div><span>- FlipBitTest: new jtreg
            test reproducing the original problem drawing a thin ellipse
            with a flipped transform<br>
          </span></div>
        <div><br>
          <span></span></div>
        <div><span>Cheers,</span></div>
        <div><span></span>Laurent</div>
      </div>
    </blockquote>
    <br>
  </div>

</div></blockquote></div><br></div></div></div></blockquote></div><br \
clear="all"><br>-- <br><div dir="ltr" class="gmail_signature">-- <br>Laurent \
Bourgès</div>



[prev in list] [next in list] [prev in thread] [next in thread]