[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR [XS] 8230769: BufImg_SetupICM add ReleasePrimitiveArrayCritical call in ear
From: "Baesken, Matthias" <matthias.baesken () sap ! com>
Date: 2019-09-10 7:04:15
Message-ID: AM6PR02MB507838C6117462904899ED0C93B60 () AM6PR02MB5078 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
Thanks for the review .
> While looking at the code I saw that we escape two critical arrays via \
> BufImg_GetRasInfo(). I guess its okay if all caller code to GetRasInfo() in the JDK \
> are properly closed with the associated release function; still it made me a bit \
> apprehensive.
I hope too that the callers of GetRasInfo always call the release function 😊 , I \
briefly checked and it looked okay to me .
Best regards, Matthias
From: Thomas Stüfe <thomas.stuefe@gmail.com>
Sent: Dienstag, 10. September 2019 08:17
To: Baesken, Matthias <matthias.baesken@sap.com>
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR [XS] 8230769: BufImg_SetupICM add \
ReleasePrimitiveArrayCritical call in early return
Looks good Matthias.
While looking at the code I saw that we escape two critical arrays via \
BufImg_GetRasInfo().
I guess its okay if all caller code to GetRasInfo() in the JDK are properly closed \
with the associated release function; still it made me a bit apprehensive.
Cheers, Thomas
On Mon, Sep 9, 2019 at 4:52 PM Baesken, Matthias \
<matthias.baesken@sap.com<mailto:matthias.baesken@sap.com>> wrote: Hello, please \
review the following webrev .
I noticed that in function BufImg_SetupICM, in case of initCubemap returning NULL \
we currently miss a ReleasePrimitiveArrayCritical call; this should be added.
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8230769
http://cr.openjdk.java.net/~mbaesken/webrevs/8230769.0/
Thanks, Matthias
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Thanks for the \
review .<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">>While looking at the code I saw that we \
escape two critical arrays via BufImg_GetRasInfo(). <o:p></o:p></span></p> \
<p class="MsoNormal"><span lang="EN-US">>I guess its okay if all caller code to \
GetRasInfo() in the JDK are properly closed with the associated release function; \
still it made me a bit apprehensive.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US">I hope too \
that the callers of </span><span lang="EN-US">GetRasInfo always call the \
release function </span><span lang="EN-US" style="font-family:"Segoe UI \
Emoji",sans-serif">😊</span><span lang="EN-US"> , I briefly checked \
and it looked okay to me .</span><span lang="EN-US" \
style="mso-fareast-language:EN-US"><o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US">Best regards, \
Matthias<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <div \
style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Thomas \
Stüfe <thomas.stuefe@gmail.com> <br>
<b>Sent:</b> Dienstag, 10. September 2019 08:17<br>
<b>To:</b> Baesken, Matthias <matthias.baesken@sap.com><br>
<b>Cc:</b> 2d-dev@openjdk.java.net<br>
<b>Subject:</b> Re: [OpenJDK 2D-Dev] RFR [XS] 8230769: BufImg_SetupICM add \
ReleasePrimitiveArrayCritical call in early return<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Looks good Matthias.<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">While looking at the code I saw that we escape two critical \
arrays via BufImg_GetRasInfo(). <o:p></o:p></p> </div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I guess its okay if all caller code to GetRasInfo() in the JDK \
are properly closed with the associated release function; still it made me a bit \
apprehensive.<o:p></o:p></p> </div>
<div>
<p class="MsoNormal"><br>
Cheers, Thomas<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Mon, Sep 9, 2019 at 4:52 PM Baesken, Matthias <<a \
href="mailto:matthias.baesken@sap.com">matthias.baesken@sap.com</a>> \
wrote:<o:p></o:p></p> </div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm \
6.0pt;margin-left:4.8pt;margin-right:0cm"> <div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US">Hello, please review the following webrev \
.</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">I \
noticed that in function BufImg_SetupICM, in case of initCubemap \
returning NULL we currently miss a ReleasePrimitiveArrayCritical call;<br> this \
should be added.</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US">Bug/webrev :</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><a \
href="https://bugs.openjdk.java.net/browse/JDK-8230769" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8230769</a><o:p></o:p></p> \
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><a \
href="http://cr.openjdk.java.net/~mbaesken/webrevs/8230769.0/" \
target="_blank">http://cr.openjdk.java.net/~mbaesken/webrevs/8230769.0/</a><o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Thanks, \
Matthias<o:p></o:p></p> </div>
</div>
</blockquote>
</div>
</div>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic