[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] <AWT Dev> [10] Review Request: 8182410, 8183508, 8181289
From: Semyon Sadetsky <semyon.sadetsky () oracle ! com>
Date: 2017-10-26 1:31:40
Message-ID: fa57e431-e6a6-8f32-d7c9-517df18725ab () oracle ! com
[Download RAW message or body]
Hi Jonathan,
On 10/24/2017 03:20 PM, Jonathan Gibbons wrote:
>
> Semyon,
>
> Although id is a global attribute and can be used to identify any
> node, some browsers do better navigation/scrolling when the id is in
> an <a> tag. We have seen poor autoscrolling behavior when the id is
> an a header tag, such that the header ends up obscured under the
> navigation bar at the top of the page.
You probably meant heading elements, because "header tag" is something
different. Do you have any references those issues reports? Because in
html5 the fragment identifiers are the only correct way to have internal
document bookmarks [1] [2]. If some browsers do not navigate to fragment
identifiers except for <a> element there must be bugs reported that
which will be fixed soon.
The html5 specification is very specific about navigating to the
fragment identifier [3]. So, there should no be difference between
navigating to "<a id=" or to any other element having id attribute. If
you just need an extra vertical space above header you could use css
style or <p>, but usage of <a> as an upper margin seems odd since it is
a special tag.
--Semyon
[1] https://www.w3schools.com/html/html_links.asp
[2] http://www.html5-tutorials.org/html-basics/links/
[3] https://www.w3.org/TR/html5/browsers.html#scroll-to-fragid
>
> -- Jon
>
>
> On 10/23/2017 10:08 PM, Semyon Sadetsky wrote:
>> Hi Sergey,
>>
>> I see no reason to have an extra empty anchor tag to set a bookmark.
>> The id attribute works with any element.
>>
>> For example:
>>
>> <a id="Definitions"></a>
>> <h3>Definitions</h3>
>>
>> should be
>>
>> <h3 id="Definitions">Definitions</h3>
>>
>> --Semyon
>>
>> On 10/23/2017 02:42 PM, Sergey Bylokhov wrote:
>>>
>>> Hello,
>>> Please review the fix for.
>>> 8182410: missing 'title' in
>>> api/javax/swing/plaf/synth/doc-files/componentProperties.html
>>> 8183508: multi_tsc.html should be updated
>>> 8181289: Invalid HTML 5 in AWT/Swing docs
>>>
>>> Description:
>>> - Illegal characters were removed.
>>> - Unsupported tags/properties were removed -like <tt>, <center>,
>>> font, etc.(except the tags related to tables which I'll fix later).
>>> - HTML5 doctype is set for all files.
>>> - The <title> is set for all files.
>>> - <a name="" is replaced by <a id=""
>> Why you replace
>>
>>> - Copyrights were added to some files.
>>>
>>> Note that I placed a <head> tag before copyright to solve errors like:
>>> "A charset attribute on a meta element found after the first 1024
>>> bytes. Fatal Error: Changing encoding at this point would need
>>> non-streamable behavior"
>>>
>>> specdiff:
>>> http://cr.openjdk.java.net/~serb/8181289/specdiff/overview-summary.html
>>>
>>> Bugs:
>>> https://bugs.openjdk.java.net/browse/JDK-8182410
>>> https://bugs.openjdk.java.net/browse/JDK-8183508
>>> https://bugs.openjdk.java.net/browse/JDK-8181289
>>>
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/8181289/webrev.00
>>>
>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Jonathan,</p>
<br>
<div class="moz-cite-prefix">On 10/24/2017 03:20 PM, Jonathan
Gibbons wrote:<br>
</div>
<blockquote type="cite" cite="mid:59EFBCA5.3090402@oracle.com">
<br>
Semyon,
<br>
<br>
Although id is a global attribute and can be used to identify any
node, some browsers do better navigation/scrolling when the id is
in an <a> tag. We have seen poor autoscrolling behavior
when the id is an a header tag, such that the header ends up
obscured under the navigation bar at the top of the page.
<br>
</blockquote>
You probably meant <span style="color: rgb(0, 0, 0); font-family:
Verdana, sans-serif; font-size: 15px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial; display: inline !important; float: none;">heading
elements, because "header tag" is something different. Do you have
any references those issues reports? Because in html5 the fragment
identifiers are the only correct way to have internal document
bookmarks [1] [2]. If some browsers do not navigate to </span><span
style="color: rgb(0, 0, 0); font-family: Verdana, sans-serif;
font-size: 15px; font-style: normal; font-variant-ligatures:
normal; font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; orphans: 2; text-align: start;
text-indent: 0px; text-transform: none; white-space: normal;
widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); text-decoration-style:
initial; text-decoration-color: initial; display: inline
!important; float: none;"><span style="color: rgb(0, 0, 0);
font-family: Verdana, sans-serif; font-size: 15px; font-style:
normal; font-variant-ligatures: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial; display: inline !important; float: none;">fragment
identifiers</span> except for <a> element there must be
bugs reported that which will be fixed soon.<br>
The html5 specification is very specific about navigating to the
fragment identifier [3]. So, there should no be difference between
navigating to "<a id=" or to any other element having id
attribute. If you just need an extra vertical space above header
you could use css style or <p>, but usage of <a> as an
upper margin seems odd since it is a special tag. <br>
<br>
--Semyon<br>
<br>
[1] <a class="moz-txt-link-freetext" \
href="https://www.w3schools.com/html/html_links.asp">https://www.w3schools.com/html/html_links.asp</a><br>
[2] <a class="moz-txt-link-freetext" \
href="http://www.html5-tutorials.org/html-basics/links/">http://www.html5-tutorials.org/html-basics/links/</a><br>
[3] <a class="moz-txt-link-freetext" \
href="https://www.w3.org/TR/html5/browsers.html#scroll-to-fragid">https://www.w3.org/TR/html5/browsers.html#scroll-to-fragid</a><br>
<br>
</span>
<blockquote type="cite" cite="mid:59EFBCA5.3090402@oracle.com">
<br>
-- Jon
<br>
<br>
<br>
On 10/23/2017 10:08 PM, Semyon Sadetsky wrote:
<br>
<blockquote type="cite">Hi Sergey,
<br>
<br>
I see no reason to have an extra empty anchor tag to set a
bookmark. The id attribute works with any element.
<br>
<br>
For example:
<br>
<br>
<a id="Definitions"></a>
<br>
<h3>Definitions</h3>
<br>
<br>
should be
<br>
<br>
<h3 id="Definitions">Definitions</h3>
<br>
<br>
--Semyon
<br>
<br>
On 10/23/2017 02:42 PM, Sergey Bylokhov wrote:
<br>
<blockquote type="cite">
<br>
Hello,
<br>
Please review the fix for.
<br>
8182410: missing 'title' in
api/javax/swing/plaf/synth/doc-files/componentProperties.html
<br>
8183508: multi_tsc.html should be updated
<br>
8181289: Invalid HTML 5 in AWT/Swing docs
<br>
<br>
Description:
<br>
- Illegal characters were removed.
<br>
- Unsupported tags/properties were removed -like <tt>,
<center>, font, etc.(except the tags related to tables
which I'll fix later).
<br>
- HTML5 doctype is set for all files.
<br>
- The <title> is set for all files.
<br>
- <a name="" is replaced by <a id=""
<br>
</blockquote>
Why you replace
<br>
<br>
<blockquote type="cite"> - Copyrights were added to some files.
<br>
<br>
Note that I placed a <head> tag before copyright to
solve errors like:
<br>
"A charset attribute on a meta element found after the first
1024 bytes. Fatal Error: Changing encoding at this point would
need non-streamable behavior"
<br>
<br>
specdiff:
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~serb/8181289/specdiff/overview-summary.html">http://cr.openjdk.java.net/~serb/8181289/specdiff/overview-summary.html</a>
<br>
<br>
Bugs:
<br>
<a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8182410">https://bugs.openjdk.java.net/browse/JDK-8182410</a>
<br>
<a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8183508">https://bugs.openjdk.java.net/browse/JDK-8183508</a>
<br>
<a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8181289">https://bugs.openjdk.java.net/browse/JDK-8181289</a>
<br>
<br>
Webrev can be found at:
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~serb/8181289/webrev.00">http://cr.openjdk.java.net/~serb/8181289/webrev.00</a>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic