[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8170681 : Remove fontconfig header files from JDK source tree
From:       Erik Joelsson <erik.joelsson () oracle ! com>
Date:       2017-10-25 15:53:49
Message-ID: 97d42e38-a059-858a-eb8f-48bad5275c98 () oracle ! com
[Download RAW message or body]

Looks good.

/Erik


On 2017-10-25 17:44, Phil Race wrote:
> Updated webrev posted as http://cr.openjdk.java.net/~prr/8170681.1
>
> -phil.
>
> On 10/25/2017 01:04 AM, Erik Joelsson wrote:
>> Hello,
>>
>> Expanding the help as Sergey suggests is a good idea. The package on 
>> Ubuntu is called libfontconfig1-dev and on Redhat fontconfig-devel.
>>
>> In lib-fontconfig.m4, line 72, no need to look for the same header 
>> twice.
>>
>> Otherwise this looks good.
>>
>> /Erik
>>
>>
>> On 2017-10-24 23:15, Philip Race wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8170681
>>> Webrev: http://cr.openjdk.java.net/~prr/8170681/
>>>
>>> This fix removes the copy of fontconfig.h from the JDK sources.
>>>
>>> The file was originally included in the JDK sources because the
>>> build platforms of the day were too old to include it.
>>>
>>> It will henceforth rely on finding it in the build environment for
>>> Linux and Solaris.
>>>
>>> The build has been tested on all platforms.
>>>
>>> The updated generated-configure.sh is not shown here since its
>>> diff is not useful (easy to read) but will be checked in as part of 
>>> the fix.
>>>
>>> -phil.
>>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]