[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] <AWT Dev> Review request for 8034218: AIX: Provide a better fontconfig.properti
From: Jonathan Lu <luchsh () linux ! vnet ! ibm ! com>
Date: 2014-05-20 6:17:42
Message-ID: CAC-GWLdwcd7=_C3R4e_tpvUDKS30w1aGA_oBcmTKLG2MginWgQ () mail ! gmail ! com
[Download RAW message or body]
Hi Volker,
I've updated the patch by dropping the those fonts configurations from
$JRE_LIB_FONTS directory.
The change is based on the SAP version, current change is primarily adding
support for CJK fonts, pls review.
http://cr.openjdk.java.net/~luchsh/JDK-8034218.v2/
Thanks
Jonathan
On Tue, May 13, 2014 at 5:25 PM, Volker Simonis <volker.simonis@gmail.com>wrote:
> Hi Jonathan,
>
> from all fontconfig files in make/data/fontconfig,
> solaris.fontconfig.properties is the only file which contains a single
> line referring to $JRE_LIB_FONTS. This is obviously a first-day bug
> which should be fixed.
>
> It simply makes no sense to define font files and default fonts with
> references to files which won't be in a JDK for sure. Again, if you
> could convince IBM to donate the corresponding fonts to the OpenJDK
> that would be great. Otherwise these entries should be dropped from
> the fontconfig files.
>
> Thank you and best regards,
> Volker
>
>
> On Tue, May 13, 2014 at 4:06 AM, Jonathan Lu <luchsh@linux.vnet.ibm.com>
> wrote:
> > Hi Phil, Volker,
> >
> > Thanks for your comments, but I noticed that JRE_LIB_FONTS has been
> referred
> > by the solaris fontconfig file,
> >
> > jdk/make/data/fontconfig/solaris.fontconfig.properties
> >
> > So I'm wondering if we can do this in the same way as Solaris platform.
> >
> >
> > Thanks
> > Jonathan
> >
> >
> >
> > On Tue, May 13, 2014 at 12:47 AM, Phil Race <philip.race@oracle.com>
> wrote:
> >>
> >> removed awt-dev ...
> >>
> >>
> >> > I don't think we should reference the fonts
> >> > under $JRE_LIB_FONTS/ in the OpenJDK version of fontconfig.properties
> >>
> >> Volker is correct on this point.
> >>
> >> Since OpenJDK can't ship those fonts we made sure they were never used
> >> in any openjdk fontconfig file.
> >>
> >> -phil.
> >>
> >>
> >>
> >> On 05/12/2014 09:42 AM, Phil Race wrote:
> >>>
> >>> All,
> >>>
> >>> If you want to continue this discussion i should be restarted on 2d-dev
> >>> and awt-dev removed. AWT has nothing to do with the fonts ..
> >>> I've fixed the bug sub-cat.
> >>>
> >>> -phil.
> >>>
> >>> On 05/12/2014 09:06 AM, Volker Simonis wrote:
> >>>>
> >>>> Hi Jonathan,
> >>>>
> >>>> thanks for submitting this patch.
> >>>>
> >>>> Overall it looks good, but I don't think we should reference the fonts
> >>>> under $JRE_LIB_FONTS/ in the OpenJDK version of fontconfig.properties
> >>>> (at least not until IBM will not also contribute the corresponding
> >>>> fonts :)
> >>>>
> >>>> I would also find it helpful to keep a reworked version of the
> comment:
> >>>>
> >>>> 27 # Minimal version for AIX using the standard Latin Type1 Fonts
> >>>> from the
> >>>> 28 # package X11.fnt.iso_T1. These fonts are installed by default
> >>>> into
> >>>> 29 # "/usr/lpp/X11/lib/X11/fonts/Type1" and sym-linked to
> >>>> "/usr/lib/X11/fonts/Type1"
> >>>>
> >>>> which mentions which AIX packages provide the other referenced font
> >>>> files.
> >>>>
> >>>> Thank you and best regards,
> >>>> Volker
> >>>>
> >>>>
> >>>>
> >>>> On Mon, May 12, 2014 at 12:37 PM, Jonathan Lu
> >>>> <luchsh@linux.vnet.ibm.com> wrote:
> >>>>>
> >>>>> Hi awt-dev,
> >>>>>
> >>>>> Please review the fix for issue:
> >>>>> https://bugs.openjdk.java.net/browse/JDK-8034218
> >>>>>
> >>>>> The changes are placed at
> >>>>> http://cr.openjdk.java.net/~luchsh/JDK-8034218/
> >>>>>
> >>>>> This patch is trying to provide a better fonctconfig.properties file
> >>>>> for AIX
> >>>>> platform,
> >>>>> which contains support for more languages, like CJK.
> >>>>>
> >>>>>
> >>>>> Thanks
> >>>>> Jonathan
> >>>>>
> >>>>>
> >>>
> >>
> >
>
[Attachment #3 (text/html)]
<div dir="ltr"><div><div>Hi Volker,<br><br></div>I've updated the patch by \
dropping the those fonts configurations from $JRE_LIB_FONTS directory.<br>The change \
is based on the SAP version, current change is primarily adding support for CJK \
fonts, pls review.<br> <br><a \
href="http://cr.openjdk.java.net/~luchsh/JDK-8034218.v2/">http://cr.openjdk.java.net/~ \
luchsh/JDK-8034218.v2/</a><br><br></div>Thanks<br><div><div>Jonathan<br></div></div></div><div \
class="gmail_extra"><br><br><div class="gmail_quote"> On Tue, May 13, 2014 at 5:25 \
PM, Volker Simonis <span dir="ltr"><<a href="mailto:volker.simonis@gmail.com" \
target="_blank">volker.simonis@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi Jonathan,<br>
<br>
from all fontconfig files in make/data/fontconfig,<br>
solaris.fontconfig.properties is the only file which contains a single<br>
line referring to $JRE_LIB_FONTS. This is obviously a first-day bug<br>
which should be fixed.<br>
<br>
It simply makes no sense to define font files and default fonts with<br>
references to files which won't be in a JDK for sure. Again, if you<br>
could convince IBM to donate the corresponding fonts to the OpenJDK<br>
that would be great. Otherwise these entries should be dropped from<br>
the fontconfig files.<br>
<div class="im HOEnZb"><br>
Thank you and best regards,<br>
Volker<br>
<br>
<br>
</div><div class="HOEnZb"><div class="h5">On Tue, May 13, 2014 at 4:06 AM, Jonathan \
Lu <<a href="mailto:luchsh@linux.vnet.ibm.com">luchsh@linux.vnet.ibm.com</a>> \
wrote:<br> > Hi Phil, Volker,<br>
><br>
> Thanks for your comments, but I noticed that JRE_LIB_FONTS has been referred<br>
> by the solaris fontconfig file,<br>
><br>
> jdk/make/data/fontconfig/solaris.fontconfig.properties<br>
><br>
> So I'm wondering if we can do this in the same way as Solaris platform.<br>
><br>
><br>
> Thanks<br>
> Jonathan<br>
><br>
><br>
><br>
> On Tue, May 13, 2014 at 12:47 AM, Phil Race <<a \
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>> wrote:<br> \
>><br> >> removed awt-dev ...<br>
>><br>
>><br>
>> > I don't think we should reference the fonts<br>
>> > under $JRE_LIB_FONTS/ in the OpenJDK version of \
fontconfig.properties<br> >><br>
>> Volker is correct on this point.<br>
>><br>
>> Since OpenJDK can't ship those fonts we made sure they were never \
used<br> >> in any openjdk fontconfig file.<br>
>><br>
>> -phil.<br>
>><br>
>><br>
>><br>
>> On 05/12/2014 09:42 AM, Phil Race wrote:<br>
>>><br>
>>> All,<br>
>>><br>
>>> If you want to continue this discussion i should be restarted on \
2d-dev<br> >>> and awt-dev removed. AWT has nothing to do with the fonts \
..<br> >>> I've fixed the bug sub-cat.<br>
>>><br>
>>> -phil.<br>
>>><br>
>>> On 05/12/2014 09:06 AM, Volker Simonis wrote:<br>
>>>><br>
>>>> Hi Jonathan,<br>
>>>><br>
>>>> thanks for submitting this patch.<br>
>>>><br>
>>>> Overall it looks good, but I don't think we should reference the \
fonts<br> >>>> under $JRE_LIB_FONTS/ in the OpenJDK version of \
fontconfig.properties<br> >>>> (at least not until IBM will not also \
contribute the corresponding<br> >>>> fonts :)<br>
>>>><br>
>>>> I would also find it helpful to keep a reworked version of the \
comment:<br> >>>><br>
>>>> 27 # Minimal version for AIX using the standard Latin Type1 \
Fonts<br> >>>> from the<br>
>>>> 28 # package X11.fnt.iso_T1. These fonts are installed by \
default<br> >>>> into<br>
>>>> 29 # "/usr/lpp/X11/lib/X11/fonts/Type1" and \
sym-linked to<br> >>>> "/usr/lib/X11/fonts/Type1"<br>
>>>><br>
>>>> which mentions which AIX packages provide the other referenced \
font<br> >>>> files.<br>
>>>><br>
>>>> Thank you and best regards,<br>
>>>> Volker<br>
>>>><br>
>>>><br>
>>>><br>
>>>> On Mon, May 12, 2014 at 12:37 PM, Jonathan Lu<br>
>>>> <<a \
href="mailto:luchsh@linux.vnet.ibm.com">luchsh@linux.vnet.ibm.com</a>> wrote:<br> \
>>>>><br> >>>>> Hi awt-dev,<br>
>>>>><br>
>>>>> Please review the fix for issue:<br>
>>>>> <a href="https://bugs.openjdk.java.net/browse/JDK-8034218" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8034218</a><br> \
>>>>><br> >>>>> The changes are placed at<br>
>>>>> <a href="http://cr.openjdk.java.net/~luchsh/JDK-8034218/" \
target="_blank">http://cr.openjdk.java.net/~luchsh/JDK-8034218/</a><br> \
>>>>><br> >>>>> This patch is trying to provide a \
better fonctconfig.properties file<br> >>>>> for AIX<br>
>>>>> platform,<br>
>>>>> which contains support for more languages, like CJK.<br>
>>>>><br>
>>>>><br>
>>>>> Thanks<br>
>>>>> Jonathan<br>
>>>>><br>
>>>>><br>
>>><br>
>><br>
><br>
</div></div></blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic