[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Trying to understand changeset 1010:467e4f25965c for lcms
From:       aph () redhat ! com (Andrew Haley)
Date:       2009-05-08 10:00:31
Message-ID: 4A0402BF.6010507 () redhat ! com
[Download RAW message or body]

Phil Race wrote:

> Andrew Haley wrote:
>> Phil Race wrote:
>>
>> The bug is at https://bugs.openjdk.java.net/show_bug.cgi?id=100050, with
>> a suggested patch attached to it.  Please have a look and let me know if
>> I can push the patch to 6-open and jdk7.  If you need webrevs as well as
>> the patch I can provide them.
> 
> I see it, although I was thrown at first. since it looks like
> a patch to go from your fixed version back to the current state.
> [Ah .. I think I just see that you uploaded a corrected version].
> I'll give it a whirl in a bit.

OK.  The patch is a very cautious approach to fixing the bug: it might
be that we simply should move the call of grow() to after we have read
the previous contents of the profile.  But there must have been some
reason why that call was moved, and I'd like to know in order to avoid
breaking something else.

> Jennifer is coordinating getting webrevs archived and getting
> reviews properly documented. She'll pick this up and you can
> coordinate how to push with her.

Righto.  In the meantime OpenJDK is broken, so I'll have to make this
an IcedTea local patch in order to fix Java compatibility.

Andrew.


[prev in list] [next in list] [prev in thread] [next in thread]