[prev in list] [next in list] [prev in thread] [next in thread]
List: openembedded-core
Subject: Re: [OE-core][PATCH] openssl: extract legacy provider module to a separate package
From: "Christopher Larson" <kergoth () gmail ! com>
Date: 2022-04-29 23:33:00
Message-ID: CABcZANmywE3Wp8e5ufiJ84=j-T+41E4zmP4SXBF+oR69NiRZWg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Just to clarify, you can certainly make rdepends of a subpackage depend on
a packageconfig, you just use inline python to do it. There are a number of
examples of this sort of conditional in oe-core.
On Fri, Apr 29, 2022 at 11:17 AM Steve Sakoman <sakoman@gmail.com> wrote:
> On Fri, Apr 29, 2022 at 2:27 AM Peter Marko <peter.marko@siemens.com>
> wrote:
> >
> > This is important for seamless migration of applications to openssl3.
> > In particular poco from meta-oe needs this as packageconfig cannot add
> rdepends to a sub-package.
> > Could this be picked to kirkstone or do I need to send it as new patch?
>
> No need to send a patch, I'll cherry-pick it in my next patch set.
>
> Thanks,
>
> Steve
>
> > > -----Original Message-----
> > > From: Marko, Peter <Peter.Marko@siemens.com>
> > > Sent: Tuesday, April 19, 2022 13:21
> > > To: openembedded-core@lists.openembedded.org
> > > Cc: Marko, Peter <Peter.Marko@siemens.com>
> > > Subject: [OE-core][PATCH] openssl: extract legacy provider module to a
> separate package
> > >
> > > This module contains legacy cipher suites from libcrypto.
> > > We should not need to include base package because we want
> > > to use this part of libcrypto.
> > >
> > > Signed-off-by: Peter Marko <peter.marko@siemens.com>
> > > ---
> > > meta/recipes-connectivity/openssl/openssl_3.0.2.bb | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta/recipes-connectivity/openssl/openssl_3.0.2.bb
> b/meta/recipes-connectivity/openssl/openssl_3.0.2.bb
> > > index ff2a22c6c3..a809666aa7 100644
> > > --- a/meta/recipes-connectivity/openssl/openssl_3.0.2.bb
> > > +++ b/meta/recipes-connectivity/openssl/openssl_3.0.2.bb
> > > @@ -224,7 +224,7 @@ do_install_ptest () { # file to be installed for
> both the openssl-bin package and the libcrypto # package since the
> openssl-bin package depends on the libcrypto package.
> > >
> > > -PACKAGES =+ "libcrypto libssl openssl-conf ${PN}-engines ${PN}-misc"
> > > +PACKAGES =+ "libcrypto libssl openssl-conf ${PN}-engines ${PN}-misc
> ${PN}-ossl-module-legacy"
> > >
> > > FILES:libcrypto = "${libdir}/libcrypto${SOLIBS}"
> > > FILES:libssl = "${libdir}/libssl${SOLIBS}"
> > > @@ -235,12 +235,13 @@ FILES:${PN}-engines = "${libdir}/engines-3"
> > > # ${prefix} comes from what we pass into --prefix at configure time
> (which is used for INSTALLTOP)
> FILES:${PN}-engines:append:mingw32:class-nativesdk = "
> ${prefix}${libdir}/engines-3"
> > > FILES:${PN}-misc = "${libdir}/ssl-3/misc ${bindir}/c_rehash"
> > > +FILES:${PN}-ossl-module-legacy = "${libdir}/ossl-modules/legacy.so"
> > > FILES:${PN} =+ "${libdir}/ssl-3/* ${libdir}/ossl-modules/"
> > > FILES:${PN}:append:class-nativesdk = "
> ${SDKPATHNATIVE}/environment-setup.d/openssl.sh"
> > >
> > > CONFFILES:openssl-conf = "${sysconfdir}/ssl/openssl.cnf"
> > >
> > > -RRECOMMENDS:libcrypto += "openssl-conf"
> > > +RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
> > > RDEPENDS:${PN}-misc = "perl"
> > > RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
> > >
> > > --
> > > 2.30.2
> >
> >
> >
> >
>
>
>
>
--
Christopher Larson
chris_larson@mentor.com, chris.larson@siemens.com, kergoth@gmail.com
Principal Software Engineer, Embedded Linux Solutions, Siemens Digital
Industries Software
[Attachment #5 (text/html)]
<div dir="ltr">Just to clarify, you can certainly make rdepends of a subpackage \
depend on a packageconfig, you just use inline python to do it. There are a number of \
examples of this sort of conditional in oe-core.</div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 29, 2022 at 11:17 \
AM Steve Sakoman <<a href="mailto:sakoman@gmail.com">sakoman@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Apr 29, 2022 \
at 2:27 AM Peter Marko <<a href="mailto:peter.marko@siemens.com" \
target="_blank">peter.marko@siemens.com</a>> wrote:<br> ><br>
> This is important for seamless migration of applications to openssl3.<br>
> In particular poco from meta-oe needs this as packageconfig cannot add rdepends \
to a sub-package.<br> > Could this be picked to kirkstone or do I need to send it \
as new patch?<br> <br>
No need to send a patch, I'll cherry-pick it in my next patch set.<br>
<br>
Thanks,<br>
<br>
Steve<br>
<br>
> > -----Original Message-----<br>
> > From: Marko, Peter <<a href="mailto:Peter.Marko@siemens.com" \
target="_blank">Peter.Marko@siemens.com</a>><br> > > Sent: Tuesday, April \
19, 2022 13:21<br> > > To: <a \
href="mailto:openembedded-core@lists.openembedded.org" \
target="_blank">openembedded-core@lists.openembedded.org</a><br> > > Cc: Marko, \
Peter <<a href="mailto:Peter.Marko@siemens.com" \
target="_blank">Peter.Marko@siemens.com</a>><br> > > Subject: \
[OE-core][PATCH] openssl: extract legacy provider module to a separate package<br> \
> ><br> > > This module contains legacy cipher suites from libcrypto.<br>
> > We should not need to include base package because we want<br>
> > to use this part of libcrypto.<br>
> ><br>
> > Signed-off-by: Peter Marko <<a href="mailto:peter.marko@siemens.com" \
target="_blank">peter.marko@siemens.com</a>><br> > > ---<br>
> > meta/recipes-connectivity/openssl/<a href="http://openssl_3.0.2.bb" \
rel="noreferrer" target="_blank">openssl_3.0.2.bb</a> | 5 +++--<br> > > 1 \
file changed, 3 insertions(+), 2 deletions(-)<br> > ><br>
> > diff --git a/meta/recipes-connectivity/openssl/<a \
href="http://openssl_3.0.2.bb" rel="noreferrer" target="_blank">openssl_3.0.2.bb</a> \
b/meta/recipes-connectivity/openssl/<a href="http://openssl_3.0.2.bb" \
rel="noreferrer" target="_blank">openssl_3.0.2.bb</a><br> > > index \
ff2a22c6c3..a809666aa7 100644<br> > > --- \
a/meta/recipes-connectivity/openssl/<a href="http://openssl_3.0.2.bb" \
rel="noreferrer" target="_blank">openssl_3.0.2.bb</a><br> > > +++ \
b/meta/recipes-connectivity/openssl/<a href="http://openssl_3.0.2.bb" \
rel="noreferrer" target="_blank">openssl_3.0.2.bb</a><br> > > @@ -224,7 +224,7 \
@@ do_install_ptest () { # file to be installed for both the openssl-bin package \
and the libcrypto # package since the openssl-bin package depends on the libcrypto \
package.<br> > ><br>
> > -PACKAGES =+ "libcrypto libssl openssl-conf ${PN}-engines \
${PN}-misc"<br> > > +PACKAGES =+ "libcrypto libssl openssl-conf \
${PN}-engines ${PN}-misc ${PN}-ossl-module-legacy"<br> > ><br>
> > FILES:libcrypto = "${libdir}/libcrypto${SOLIBS}"<br>
> > FILES:libssl = "${libdir}/libssl${SOLIBS}"<br>
> > @@ -235,12 +235,13 @@ FILES:${PN}-engines = \
"${libdir}/engines-3"<br> > > # ${prefix} comes from what we pass \
into --prefix at configure time (which is used for INSTALLTOP) \
FILES:${PN}-engines:append:mingw32:class-nativesdk = " \
${prefix}${libdir}/engines-3"<br> > > FILES:${PN}-misc = \
"${libdir}/ssl-3/misc ${bindir}/c_rehash"<br> > > \
+FILES:${PN}-ossl-module-legacy = "${libdir}/ossl-modules/legacy.so"<br> \
> > FILES:${PN} =+ "${libdir}/ssl-3/* ${libdir}/ossl-modules/"<br> \
> > FILES:${PN}:append:class-nativesdk = " \
${SDKPATHNATIVE}/environment-setup.d/openssl.sh"<br> > ><br>
> > CONFFILES:openssl-conf = "${sysconfdir}/ssl/openssl.cnf"<br>
> ><br>
> > -RRECOMMENDS:libcrypto += "openssl-conf"<br>
> > +RRECOMMENDS:libcrypto += "openssl-conf \
${PN}-ossl-module-legacy"<br> > > RDEPENDS:${PN}-misc = \
"perl"<br> > > RDEPENDS:${PN}-ptest += "openssl-bin perl \
perl-modules bash sed"<br> > ><br>
> > --<br>
> > 2.30.2<br>
><br>
><br>
> <br>
><br>
<br>
<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature"><div dir="ltr"><div dir="ltr"><font \
color="#333333">Christopher Larson<br><a>chris_larson@mentor.com</a>, \
<a>chris.larson@siemens.com</a>, <a>kergoth@gmail.com</a><br>Principal Software \
Engineer, Embedded Linux Solutions, Siemens Digital Industries \
Software</font><br></div></div></div>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#165061): https://lists.openembedded.org/g/openembedded-core/message/165061
Mute This Topic: https://lists.openembedded.org/mt/90559122/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic