[prev in list] [next in list] [prev in thread] [next in thread]
List: openembedded-core
Subject: Re: [OE-core] [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used
From: "Khem Raj" <raj.khem () gmail ! com>
Date: 2022-04-29 22:45:43
Message-ID: CAMKF1spqf5BG974EnyqR3fDb3-w2O79iBgXJ6O4B+836J3cRkQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Fri, Apr 29, 2022 at 3:17 PM Portia Stephens <stephensportia@gmail.com>
wrote:
> On Sat, Apr 30, 2022 at 1:39 AM Khem Raj <raj.khem@gmail.com> wrote:
> >
> >
> >
> > On 4/29/22 12:34 AM, Portia wrote:
> > > Remove setting TimeoutSec and allow the DefaultTimeSec to be set for
> the
> > > volatile-binds services.
> > >
> >
> > Whats the default value? I hope it does not go into infinite loop in
> > case the service gets stuck
> >
>
> Timeout=0 sets the Timeout to infinity, so the current behavior is
> that if the service gets stuck
> it never gets killed. DefaultTimeout will depend on what is set in the
> /etc/systemd/system.conf.
Right reading it from system default is fine I guess defaults are perhaps
around 90s which is enough for the service to load normally
>
> > > Signed-off-by: Portia Stephens <stephensportia@gmail.com>
> > > ---
> > > meta/recipes-core/volatile-binds/files/volatile-binds.service.in |
> 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-core/volatile-binds/files/
> volatile-binds.service.in b/meta/recipes-core/volatile-binds/files/
> volatile-binds.service.in
> > > index 8fe7d8d4f9..52384c8264 100644
> > > --- a/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
> > > +++ b/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
> > > @@ -10,7 +10,6 @@ ConditionPathIsReadWrite=!@where@
> > > [Service]
> > > Type=oneshot
> > > RemainAfterExit=Yes
> > > -TimeoutSec=0
> > > Environment=MOUNT_COPYBIND_AVOID_OVERLAYFS=@avoid_overlayfs@
> > > ExecStart=/sbin/mount-copybind @what@ @where@
> > > ExecStop=/bin/umount @where@
> > >
> > >
> > >
> > >
> > >
>
[Attachment #5 (text/html)]
<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Fri, Apr 29, 2022 at 3:17 PM Portia Stephens <<a \
href="mailto:stephensportia@gmail.com">stephensportia@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">On Sat, Apr 30, 2022 at 1:39 AM \
Khem Raj <<a href="mailto:raj.khem@gmail.com" \
target="_blank">raj.khem@gmail.com</a>> wrote:<br> ><br>
><br>
><br>
> On 4/29/22 12:34 AM, Portia wrote:<br>
> > Remove setting TimeoutSec and allow the DefaultTimeSec to be set for \
the<br> > > volatile-binds services.<br>
> ><br>
><br>
> Whats the default value? I hope it does not go into infinite loop in<br>
> case the service gets stuck<br>
><br>
<br>
Timeout=0 sets the Timeout to infinity, so the current behavior is<br>
that if the service gets stuck<br>
it never gets killed. DefaultTimeout will depend on what is set in the<br>
/etc/systemd/system.conf.</blockquote><div dir="auto"><br></div><div dir="auto">Right \
reading it from system default is fine I guess defaults are perhaps around 90s which \
is enough for the service to load normally </div><div \
dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex" dir="auto"><br> <br>
> > Signed-off-by: Portia Stephens <<a \
href="mailto:stephensportia@gmail.com" \
target="_blank">stephensportia@gmail.com</a>><br> > > ---<br>
> > meta/recipes-core/volatile-binds/files/<a \
href="http://volatile-binds.service.in" rel="noreferrer" \
target="_blank">volatile-binds.service.in</a> | 1 -<br> > > 1 file changed, \
1 deletion(-)<br> > ><br>
> > diff --git a/meta/recipes-core/volatile-binds/files/<a \
href="http://volatile-binds.service.in" rel="noreferrer" \
target="_blank">volatile-binds.service.in</a> \
b/meta/recipes-core/volatile-binds/files/<a href="http://volatile-binds.service.in" \
rel="noreferrer" target="_blank">volatile-binds.service.in</a><br> > > index \
8fe7d8d4f9..52384c8264 100644<br> > > --- \
a/meta/recipes-core/volatile-binds/files/<a href="http://volatile-binds.service.in" \
rel="noreferrer" target="_blank">volatile-binds.service.in</a><br> > > +++ \
b/meta/recipes-core/volatile-binds/files/<a href="http://volatile-binds.service.in" \
rel="noreferrer" target="_blank">volatile-binds.service.in</a><br> > > @@ -10,7 \
+10,6 @@ ConditionPathIsReadWrite=!@where@<br> > > [Service]<br>
> > Type=oneshot<br>
> > RemainAfterExit=Yes<br>
> > -TimeoutSec=0<br>
> > Environment=MOUNT_COPYBIND_AVOID_OVERLAYFS=@avoid_overlayfs@<br>
> > ExecStart=/sbin/mount-copybind @what@ @where@<br>
> > ExecStop=/bin/umount @where@<br>
> ><br>
> ><br>
> ><br>
> > <br>
> ><br>
</blockquote></div></div>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#165060): https://lists.openembedded.org/g/openembedded-core/message/165060
Mute This Topic: https://lists.openembedded.org/mt/90771601/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic