[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] musl: Add .file directive in crt assembly files
From:       "Andrei Gherzan" <andrei () gherzan ! ro>
Date:       2020-10-30 14:44:29
Message-ID: CAK18fxFoKB1Jx6cDPqybHBUJjWQwwRUaODcsdhO-rZEHLCkdRQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

On Fri, Oct 30, 2020 at 2:42 PM Khem Raj <raj.khem@gmail.com> wrote:

> On Fri, Oct 30, 2020 at 5:07 AM Andrei Gherzan <andrei@gherzan.ro> wrote:
> >
> >
> > On Fri, Oct 30, 2020 at 5:47 AM Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> This helps linker to noot emit absolute paths into .debug_line sections
> >> of liked binaries and libraries and therefore make them reproducible
> >>
> >> Reported-by: Andrei Gherzan <andrei@gherzan.ro>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >>  .../musl/0001-crt-Add-.file-directive.patch   | 300 ++++++++++++++++++
> >>  meta/recipes-core/musl/musl_git.bb            |   1 +
> >>  2 files changed, 301 insertions(+)
> >>  create mode 100644
> meta/recipes-core/musl/musl/0001-crt-Add-.file-directive.patch
> >
> >
> > Tested - works as expected. One small NIT to maintain consistency with
> the Glibc fix: ".S" vs ".s".
> >
>
> .file directive is to specify the name of the file so it should match
> it. In glibc the files are called .S because they are preprocessed
> through gcc
> where as the musl files are pure asm files.
>

Makes sense. Scratch that.

--
Andrei Gherzan

[Attachment #5 (text/html)]

<div dir="ltr"><div>Hi,</div><div><br></div><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Fri, Oct 30, 2020 at 2:42 PM Khem Raj &lt;<a \
href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Oct 30, 2020 \
at 5:07 AM Andrei Gherzan &lt;<a href="mailto:andrei@gherzan.ro" \
target="_blank">andrei@gherzan.ro</a>&gt; wrote:<br> &gt;<br>
&gt;<br>
&gt; On Fri, Oct 30, 2020 at 5:47 AM Khem Raj &lt;<a href="mailto:raj.khem@gmail.com" \
target="_blank">raj.khem@gmail.com</a>&gt; wrote:<br> &gt;&gt;<br>
&gt;&gt; This helps linker to noot emit absolute paths into .debug_line sections<br>
&gt;&gt; of liked binaries and libraries and therefore make them reproducible<br>
&gt;&gt;<br>
&gt;&gt; Reported-by: Andrei Gherzan &lt;<a href="mailto:andrei@gherzan.ro" \
target="_blank">andrei@gherzan.ro</a>&gt;<br> &gt;&gt; Signed-off-by: Khem Raj &lt;<a \
href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>&gt;<br> \
&gt;&gt; ---<br> &gt;&gt;   .../musl/0001-crt-Add-.file-directive.patch     | 300 \
++++++++++++++++++<br> &gt;&gt;   meta/recipes-core/musl/<a href="http://musl_git.bb" \
rel="noreferrer" target="_blank">musl_git.bb</a>                  |     1 +<br> \
&gt;&gt;   2 files changed, 301 insertions(+)<br> &gt;&gt;   create mode 100644 \
meta/recipes-core/musl/musl/0001-crt-Add-.file-directive.patch<br> &gt;<br>
&gt;<br>
&gt; Tested - works as expected. One small NIT to maintain consistency with the Glibc \
fix: &quot;.S&quot; vs &quot;.s&quot;.<br> &gt;<br>
<br>
.file directive is to specify the name of the file so it should match<br>
it. In glibc the files are called .S because they are preprocessed<br>
through gcc<br>
where as the musl files are pure asm files.<br></blockquote><div><br></div><div>Makes \
sense. Scratch that.<br></div><div><br></div><div><div>--</div>Andrei Gherzan \
<br></div></div></div>



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144005): https://lists.openembedded.org/g/openembedded-core/message/144005
Mute This Topic: https://lists.openembedded.org/mt/77906053/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]