[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: Resource: Send custom commands over the local socket instead of dbus
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2012-12-20 23:10:19
Message-ID: 20121220231019.22219.18392 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107730/#review23782
-----------------------------------------------------------
Ping?
I'm pushing this if I don't get any response soon.
- Vishesh Handa
On Dec. 14, 2012, 9:24 p.m., Vishesh Handa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107730/
> -----------------------------------------------------------
> =
> (Updated Dec. 14, 2012, 9:24 p.m.)
> =
> =
> Review request for Nepomuk and Sebastian Trueg.
> =
> =
> Description
> -------
> =
> Resource: Send custom commands over the local socket instead of dbus
> =
> We currently had a mixed system of using both dbus and sockets in the
> Resource class. It's better if we just rely on the local socket, since
> that is what the connection is there for.
> =
> This is the first step that is required to move to the data-management
> commands to use the local socket instead of dbus.
> =
> This requires some custom patches in Soprano, which I'm too lazy to put u=
p. The diff is over here http://paste.kde.org/625478/ if you really want to=
see.
> =
> =
> Diffs
> -----
> =
> libnepomukcore/CMakeLists.txt 86a3aee =
> libnepomukcore/resource/commands.h PRE-CREATION =
> libnepomukcore/resource/nepomukmainmodel.h b386ab6 =
> libnepomukcore/resource/nepomukmainmodel.cpp f18b545 =
> libnepomukcore/resource/resourcedata.cpp 86808f8 =
> libnepomukcore/resource/socketclient.h PRE-CREATION =
> libnepomukcore/resource/socketclient.cpp PRE-CREATION =
> services/storage/nepomukcore.h 4f9bed6 =
> services/storage/nepomukcore.cpp 8913dcb =
> services/storage/repository.h 630b373 =
> services/storage/repository.cpp 0cfc98f =
> =
> Diff: http://git.reviewboard.kde.org/r/107730/diff/
> =
> =
> Testing
> -------
> =
> works
> =
> =
> Thanks,
> =
> Vishesh Handa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107730/">http://git.reviewboard.kde.org/r/107730/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ping?
I'm pushing this if I don't get any response soon.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On December 14th, 2012, 9:24 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2012, 9:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Resource: Send custom commands over the local socket instead of dbus \
We currently had a mixed system of using both dbus and sockets in the
Resource class. It's better if we just rely on the local socket, since
that is what the connection is there for.
This is the first step that is required to move to the data-management
commands to use the local socket instead of dbus.
This requires some custom patches in Soprano, which I'm too lazy to put up. The \
diff is over here http://paste.kde.org/625478/ if you really want to see.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libnepomukcore/CMakeLists.txt <span style="color: grey">(86a3aee)</span></li>
<li>libnepomukcore/resource/commands.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libnepomukcore/resource/nepomukmainmodel.h <span style="color: \
grey">(b386ab6)</span></li>
<li>libnepomukcore/resource/nepomukmainmodel.cpp <span style="color: \
grey">(f18b545)</span></li>
<li>libnepomukcore/resource/resourcedata.cpp <span style="color: \
grey">(86808f8)</span></li>
<li>libnepomukcore/resource/socketclient.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libnepomukcore/resource/socketclient.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>services/storage/nepomukcore.h <span style="color: grey">(4f9bed6)</span></li>
<li>services/storage/nepomukcore.cpp <span style="color: grey">(8913dcb)</span></li>
<li>services/storage/repository.h <span style="color: grey">(630b373)</span></li>
<li>services/storage/repository.cpp <span style="color: grey">(0cfc98f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107730/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic