[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mandrake-cooker
Subject:    Re: [Cooker] Re: [cooker-commits] [svn-commit] r120262 - in
From:       Per =?utf-8?q?=C3=98yvind_Karlsen?= <pkarlsen () mandriva ! com>
Date:       2007-02-16 4:27:34
Message-ID: 200702160527.34800.pkarlsen () mandriva ! com
[Download RAW message or body]

Fredag 16 februar 2007 02:19, skrev Tomasz Paweł Gajc:
> Dnia piątek, 16 lutego 2007, Per Øyvind Karlsen napisał:
> > Tirsdag 13 februar 2007 05:35, skrev tpg:
> > > - new version
> > > - fix buildrequires
> > > - move libraries to its own package
> >
> > No!
> > This is incorrect, devel libraries (which btw. is often just symlinks) is
> > supposed to come in same package as their headers.  This change will
> > break buildrequires for other packages.
>
> Sox wasn't never libified, even if it contains shared libraries(someone
> missed it?). What about policy?
> There was no ldconfig in %post and %postun, %{major} wasn't used at all.
As said, I misread mail, good thing that you libified it. :)
>
> Yes i made mistake with spliting devel files. :(
>
> > > - set %multiarch on libst-config
> >
> > Why?
>
> Good question, which i'd like to pass down tho those who claims
> that %multiarch has to be set on those files.
> Few days ago just to be sure, i've asked on #mandriva-cooker what are
> correct bits on initscripts, i've suggested 744, there were answers like
> 755, 700, or to not set them.... unfortunately there was no 777 answer.
>
> This means there is no common policy on that cases.
It's probably because it's no sense in other permissions than 755 and 
therefore no need for dictating such a policy
>
> Rule 1:
> - set %mutliarch on %{_bindir}/*-config, if not FOAD.
> Rule 2:
> - see rule 1.
>
> > > - spec file clean
> >
> > Stop change others intended formatting of packages!
> > If people have placed several dependencies per line, it's probably due to
> > their own idea of cosmetics!
>
> Done.
>
> Speaking of making sense:
>
>   --with-sndfile          Use libsndfile if present (default is yes)
>   --with-flac             Use FLAC if present (default is yes)
>   --with-mad              Use MAD (MP3 Audio Decoder) if present (default
> is yes)
>   --with-lame             Use LAME (LAME Ain't an MP3 Encoder) if present
>                           (default is yes)
>
> Really you don't have to need add those options into %configure!
This was because I was investigating problem with flac support and I commited 
changes before continuing, --with-* does unfortunately not make configure 
error if test fails.

I have removed these flags now as well as fixed flac support, sent patch 
upstream while requesting such options for configure as well. :)
-- 
Regards,
Per Øyvind Karlsen
Mandriva

[prev in list] [next in list] [prev in thread] [next in thread]