[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mandrake-cooker
Subject:    [Cooker] [Bug 13289] [cpufreq] NEEDINFO: [PATCH] service cpufreq doesn't start
From:       "[piel]" <bugzilla () qa ! linux-mandrake ! com>
Date:       2005-01-31 20:09:42
Message-ID: bug13289.20050131200942.680151 () qa ! linux-mandrake ! com
[Download RAW message or body]

User ID: 6517, 21 bugs reported (16 fixed, 0 duplicate, 1 invalid), 41 comments.

http://qa.mandrakesoft.com/show_bug.cgi?id=13289





------- Additional Comments From piel@lifl.fr  2005-01-31 21:09 -------
There is no such module called "cpufreq". The module that provide the interface
is called "speedstep-lib" and it's already handled correctly by the script.

IMHO, the current behaviour (when including this patch) is fine:
- if the computer has no hardware support for cpufreq (and the service is
selected) then a [FAILED] will be displayed and nothing at all loaded;
- if the computer has hardware support (and the service is selected), the
correct module will be loaded and [OK] displayed.

Can it go any better? :-)

-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


------- Reminder: -------
assigned_to: erwan@mandrakesoft.com
status: NEEDINFO
distribution: cooker
creation_date: 
description: 
Hello,

If /proc/cpufreq is not compiled in the kernel then the "cpufreq" service will
not start. 

This is due to the line at the beginning of the script:
[ -d /sys/devices/system/cpu/cpu0/cpufreq ] || [ -f /proc/cpufreq ] || exit 0

This is valid for "cpufreqd" (where it's also used) but it completly breaks
everything in "cpufreq" (whose job is *exactly* to load the cpufreq interface!).

The patch consists just in removing the line:
--- cpufreq.bak 2005-01-28 12:23:57.614472117 +0100
+++ cpufreq     2005-01-28 12:24:03.432379643 +0100
@@ -13,8 +13,6 @@
 RETVAL=0
 KERNEL_TYPE=`uname -r | sed -e 's/\(2\.[2-6]\).*/\1/g'`
 
-[ -d /sys/devices/system/cpu/cpu0/cpufreq ] || [ -f /proc/cpufreq ] || exit 0
-
 #Some hardware informations
 family=`LC_ALL=C grep "cpu family" /proc/cpuinfo | awk '{print $4}' | head -1`
 vendor=`LC_ALL=C grep "vendor_id" /proc/cpuinfo | awk '{print $3}' | head -1`

Eric

[prev in list] [next in list] [prev in thread] [next in thread]