[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mandrake-cooker
Subject:    [Cooker] [Bug 13290] [cpufreq] NEEDINFO: [PATCH] cpufreq should load all the cpufreq governors
From:       "[piel]" <bugzilla () qa ! linux-mandrake ! com>
Date:       2005-01-31 20:19:07
Message-ID: bug13290.20050131201906.997812 () qa ! linux-mandrake ! com
[Download RAW message or body]

User ID: 6517, 21 bugs reported (16 fixed, 0 duplicate, 1 invalid), 41 comments.

http://qa.mandrakesoft.com/show_bug.cgi?id=13290





------- Additional Comments From piel@lifl.fr  2005-01-31 21:19 -------
cpufreq_performance? Yes! Actually I had forgot about it because it's usually
the governor compiled into the kernel. However one could select any other
governor and have "cpufreq_performance" as a module.

Concerning the point about "-" and "_", it's sliglthy ambigous but the same for
all the kernel modules: module files contain "-" in their name while module
names contain "_" (cf lsmod). To load a module with modprobe, you can use "-" or
"_", both work. However, to unload a module (with rmmod), only "_" works.

Therefore, a fix could be just to change all the names to the "_" version,
although it sounds a bit ugly...
 

-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


------- Reminder: -------
assigned_to: erwan@mandrakesoft.com
status: NEEDINFO
distribution: cooker
creation_date: 
description: 
Hello,

In the latest kernels there are 2 new cpufreq governors in addition to powersave:
userspace and on_demand. Let's note that userspace is required to run correctly
"powernowd".

The following patch add the management of those two new governors (and also
prevent the service to fail if they are compiled in kernel).
--- cpufreq.bak2	2005-01-28 12:25:57.472964978 +0100
+++ cpufreq	2005-01-28 12:39:26.718984874 +0100
@@ -168,6 +168,8 @@
 	MODULE=""
 	if find_module; then
 		if [ "$KERNEL_TYPE" = "2.6" ]; then 
+			rmmod cpufreq_ondemand 2>/dev/null
+			rmmod cpufreq_userspace 2>/dev/null
 			rmmod cpufreq_powersave 2>/dev/null
 		fi
 		rmmod $MODULE 2>/dev/null
@@ -192,13 +194,12 @@
 start() {
 	gprintf "Probing cpufreq modules : "
 	probe_modules
-        RET_PROBE=$?	
-	if [ $RET_PROBE -eq 0 ];  then
+	RETVAL=$?	
+	if [ $RETVAL -eq 0 ];  then
 		if [ "$KERNEL_TYPE" = "2.6" ]; then
 			modprobe cpufreq_powersave; 2>/dev/null 
-			RETVAL=$?
-		else
-			RETVAL=$RET_PROBE;	
+			modprobe cpufreq_userspace; 2>/dev/null 
+			modprobe cpufreq_ondemand; 2>/dev/null 
 		fi
 		[ $RETVAL -eq 0 ] && touch /var/lock/subsys/cpufreq
 		success

Eric

[prev in list] [next in list] [prev in thread] [next in thread]