[prev in list] [next in list] [prev in thread] [next in thread]
List: macports-dev
Subject: Re: [macports-ports] 02/02: py-parse: new port
From: <mf2k () macports ! org>
Date: 2018-07-25 14:58:29
Message-ID: 0FE1D435-6EE4-46C1-8412-3432AA38772D () macports ! org
[Download RAW message or body]
Hi Dan,
A few comments on this:
> On Jul 25, 2018, at 5:26 AM, Dan Villiom Podlaski Christiansen \
> <danchr@macports.org> wrote:
> Dan Villiom Podlaski Christiansen (danchr) pushed a commit to branch master
> in repository macports-ports.
>
> https://github.com/macports/macports-ports/commit/a4e4d89fd609ce7eaccbeb2915379b0c29990e9a \
> <https://github.com/macports/macports-ports/commit/a4e4d89fd609ce7eaccbeb2915379b0c29990e9a>
> commit a4e4d89fd609ce7eaccbeb2915379b0c29990e9a
> Author: Dan Villiom Podlaski Christiansen <danchr@macports.org>
> AuthorDate: Wed Jul 25 13:26:04 2018 +0200
>
> py-parse: new port
> ---
> python/py-parse/Portfile | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/python/py-parse/Portfile b/python/py-parse/Portfile
> new file mode 100644
> index 0000000..f62dae4
> --- /dev/null
> +++ b/python/py-parse/Portfile
> @@ -0,0 +1,29 @@
> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; \
> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 +
> +PortSystem 1.0
> +PortGroup python 1.0
> +
> +name py-parse
> +version 1.8.4
> +python.versions 27 34 35 36 37
In the future, for new python modules please don't add py34 and py35 sub-ports. Let's \
stick to just py36 and py37.
> +license BSD
> +platforms darwin
> +supported_archs noarch
> +maintainers openmaintainer danchr @danchr
The maintainers line is not correct. You need to add braces to show that your \
Macports handle and Github handle are related. Also, by convention, your name should \
go first. So change it to this:
maintainers {danchr @danchr} openmaintainer
> +
> +description parse() is the opposite of format()
> +long_description Parse strings using a specification based on the Python \
> + format() syntax -- parse() is the opposite of format()
> +
> +homepage https://pypi.python.org/pypi/${python.rootname}/
> +
> +master_sites pypi:[string index ${python.rootname} 0]/${python.rootname}
> +distname ${python.rootname}-${version}
> +
> +checksums sha256 \
> c3cdf6206f22aeebfa00e5b954fcfea13d1b2dc271c75806b6025b94fb490939
For integrity reasons, please add the rmd160 checksum and also the size parameter.
> +
> +
> +if {$name ne $subport} {
> + depends_build-append port:py${python.version}-setuptools
> +}
> +
>
Cheers!
Frank
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
line-break: after-white-space;" class="">Hi Dan,<div class=""><br class=""></div><div \
class=""><br class=""></div><div class="">A few comments on this:<br \
class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 25, \
2018, at 5:26 AM, Dan Villiom Podlaski Christiansen <<a \
href="mailto:danchr@macports.org" class="">danchr@macports.org</a>> \
wrote:</div><br class="Apple-interchange-newline"><div class=""><pre style="margin:0" \
class="">Dan Villiom Podlaski Christiansen (danchr) pushed a commit to branch master \
in repository macports-ports.
</pre><p class=""><a \
href="https://github.com/macports/macports-ports/commit/a4e4d89fd609ce7eaccbeb2915379b0c29990e9a" \
class="">https://github.com/macports/macports-ports/commit/a4e4d89fd609ce7eaccbeb2915379b0c29990e9a</a></p>
<pre style="white-space: pre; background: #F8F8F8" class=""><span \
style="display:block; white-space:pre;color:#808000;" class="">commit \
a4e4d89fd609ce7eaccbeb2915379b0c29990e9a </span>Author: Dan Villiom Podlaski \
Christiansen <<a href="mailto:danchr@macports.org" \
class="">danchr@macports.org</a>>
AuthorDate: Wed Jul 25 13:26:04 2018 +0200
<span style="display:block; white-space:pre;color:#404040;" class=""> py-parse: \
new port </span>---
python/py-parse/Portfile | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
<span style="display:block; white-space:pre;color:#808080;" class="">diff --git \
a/python/py-parse/Portfile b/python/py-parse/Portfile </span>new file mode 100644
<span style="display:block; white-space:pre;color:#808080;" class="">index \
0000000..f62dae4 </span><span style="display:block; \
white-space:pre;background:#ffe0e0;" class="">--- /dev/null </span><span \
style="display:block; white-space:pre;background:#e0e0ff;" class="">+++ \
b/python/py-parse/Portfile </span><span style="display:block; \
white-space:pre;background:#e0e0e0;" class="">@@ -0,0 +1,29 @@ </span><span \
style="display:block; white-space:pre;background:#e0ffe0;" class="">+# -*- coding: \
utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- \
vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+ </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+PortSystem 1.0 </span><span \
style="display:block; white-space:pre;background:#e0ffe0;" class="">+PortGroup \
python 1.0 </span><span style="display:block; white-space:pre;background:#e0ffe0;" \
class="">+ </span><span style="display:block; white-space:pre;background:#e0ffe0;" \
class="">+name py-parse </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+version 1.8.4 </span><span \
style="display:block; white-space:pre;background:#e0ffe0;" class="">+python.versions \
27 34 35 36 37 </span></pre></div></blockquote><div>In the future, for new python \
modules please don't add py34 and py35 sub-ports. Let's stick to just py36 and \
py37. </div><br class=""><blockquote type="cite" class=""><div class=""><pre \
style="white-space: pre; background: #F8F8F8" class=""><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+license BSD </span><span \
style="display:block; white-space:pre;background:#e0ffe0;" class="">+platforms \
darwin </span><span style="display:block; white-space:pre;background:#e0ffe0;" \
class="">+supported_archs noarch </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+maintainers openmaintainer \
danchr @danchr </span></pre></div></blockquote><div>The maintainers line is not \
correct. You need to add braces to show that your Macports handle and Github handle \
are related. Also, by convention, your name should go first. So change it to \
this:</div><div><br class=""></div><div><font face="Courier" class="">maintainers \
{danchr @danchr} openmaintainer</font></div><br \
class=""><blockquote type="cite" class=""><div class=""><pre style="white-space: pre; \
background: #F8F8F8" class=""><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+ </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+description parse() is the \
opposite of format() </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+long_description Parse strings \
using a specification based on the Python \ </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+ format() syntax -- \
parse() is the opposite of format() </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+ </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+homepage <a \
href="https://pypi.python.org/pypi/${python.rootname}/" \
class="">https://pypi.python.org/pypi/${python.rootname}/</a> </span><span \
style="display:block; white-space:pre;background:#e0ffe0;" class="">+ </span><span \
style="display:block; white-space:pre;background:#e0ffe0;" class="">+master_sites \
pypi:[string index ${python.rootname} 0]/${python.rootname} </span><span \
style="display:block; white-space:pre;background:#e0ffe0;" class="">+distname \
${python.rootname}-${version} </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+ </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+checksums sha256 \
c3cdf6206f22aeebfa00e5b954fcfea13d1b2dc271c75806b6025b94fb490939 \
</span></pre></div></blockquote><div>For integrity reasons, please add the rmd160 \
checksum and also the size parameter. </div><blockquote type="cite" \
class=""><div class=""><pre style="white-space: pre; background: #F8F8F8" \
class=""><span style="display:block; white-space:pre;background:#e0ffe0;" class="">+ \
</span><span style="display:block; white-space:pre;background:#e0ffe0;" class="">+ \
</span><span style="display:block; white-space:pre;background:#e0ffe0;" class="">+if \
{$name ne $subport} { </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+ depends_build-append \
port:py${python.version}-setuptools </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+} </span><span style="display:block; \
white-space:pre;background:#e0ffe0;" class="">+ </span></pre><pre style="margin:0" \
class=""> </pre>
</div></blockquote><br class=""></div><div>Cheers!</div><div>Frank</div><br \
class=""></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic