[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-devel
Subject:    Re: [Cvslog] r26544 - /lyx-devel/trunk/lib/bind/site.bind
From:       Abdelrazak Younes <younes () lyx ! org>
Date:       2008-09-29 21:07:07
Message-ID: 48E1437B.7080502 () lyx ! org
[Download RAW message or body]

On 29/09/2008 20:29, Andre Poenitz wrote:
> On Fri, Sep 26, 2008 at 11:31:53AM +0200, Abdelrazak Younes wrote:
>    
>> Index: TocModel.cpp
>> ===================================================================
>> --- TocModel.cpp	(revision 26565)
>> +++ TocModel.cpp	(working copy)
>> @@ -45,9 +45,52 @@
>>   }
>>
>>
>> +TocModel::TocModel(QObject * parent)
>> +	: model_(new TocTypeModel(parent)),
>> +	sorted_model_(new QSortFilterProxyModel(parent)),
>> +	is_sorted_(false), maxdepth_(0), mindepth_(0)
>>      
>
> Out of curiosity: why do you use 'parent' and not 'this' as QObject parent?
>
> It does not really matter in this case, but looks a bit unusual.
>    
No particular reason, copy&paste AFAIR... The only rule is to have a 
QObject parent for proper automatic deletion so I didn't bother...

Abdel.

[prev in list] [next in list] [prev in thread] [next in thread]