[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-devel
Subject:    Re: [PATCH] Change tracking hacking
From:       Johnathan Burchill <jkerrb () users ! sourceforge ! net>
Date:       2005-02-21 16:10:25
Message-ID: 200502210910.25599.jkerrb () users ! sourceforge ! net
[Download RAW message or body]


On Monday 21 February 2005 07:08, you wrote:
> Johnathan Burchill wrote:
> > I've attached the bug fix. There's no point in providing the
> > break-paragraph patch until it's fully functional. If you want to play
> > with it, see my first attachment in this thread. Whether or not you want
> > to implement the functionality in 1.4.0, I'll work on it in the meantime,
> > and provide patches as she goes.
>
> I can confirm that it fixes bug 1277, most importantly the crash. Good
> work. It has, however, one remaining glitch:
>
> 1. new document
> 2. insert text: word1 word2 word3 <footnote>
> 3. Track changes
> 4. cut the footnote and paste it at the beginning of the par
> 5. Cut word3 and paste it at the beginning of the par
> 6. cut word 2 and paste it at the beginning of the par
> 7. cut word 1 and paste it at the beginning of the par
>
> => The erased text is beginning to get marked inserted or unchanged.
>
> Jürgen

The simplest way to reproduce it is:
2. insert "a".
3. track changes.
4. cut "a" and paste it at the beginning of the par
5. paste "a" at beginning again.
6. paste "a" at beginning again ---> problem appears (4 "a"'s all marked 
inserted).

It seems to be a problem with the change-tracking range code. Here is the 
changelist in the final state (from "lyx -dbg changes"):

Range of type 1 is 0,4 author 0 time 0
Range of type 2 is 4,5 author 0 time 0

It should be type 1 over 0,3 and type 2 over 3,4. So the deleted "a" is 
marked, but it's at position 4 in the change table_, while the actual "a" is 
at position 3.

JB

-- 
Johnathan K. Burchill, Ph.D.
jkerrb@users.sourceforge.net

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]