From lyx-devel Mon Feb 21 16:10:25 2005 From: Johnathan Burchill Date: Mon, 21 Feb 2005 16:10:25 +0000 To: lyx-devel Subject: Re: [PATCH] Change tracking hacking Message-Id: <200502210910.25599.jkerrb () users ! sourceforge ! net> X-MARC-Message: https://marc.info/?l=lyx-devel&m=110900221815996 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart1881236.QJ8fUCtnWW" --nextPart1881236.QJ8fUCtnWW Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 21 February 2005 07:08, you wrote: > Johnathan Burchill wrote: > > I've attached the bug fix. There's no point in providing the > > break-paragraph patch until it's fully functional. If you want to play > > with it, see my first attachment in this thread. Whether or not you want > > to implement the functionality in 1.4.0, I'll work on it in the meantim= e, > > and provide patches as she goes. > > I can confirm that it fixes bug 1277, most importantly the crash. Good > work. It has, however, one remaining glitch: > > 1. new document > 2. insert text: word1 word2 word3 > 3. Track changes > 4. cut the footnote and paste it at the beginning of the par > 5. Cut word3 and paste it at the beginning of the par > 6. cut word 2 and paste it at the beginning of the par > 7. cut word 1 and paste it at the beginning of the par > > =3D> The erased text is beginning to get marked inserted or unchanged. > > J=FCrgen The simplest way to reproduce it is: 2. insert "a". 3. track changes. 4. cut "a" and paste it at the beginning of the par 5. paste "a" at beginning again. 6. paste "a" at beginning again ---> problem appears (4 "a"'s all marked=20 inserted). It seems to be a problem with the change-tracking range code. Here is the=20 changelist in the final state (from "lyx -dbg changes"): Range of type 1 is 0,4 author 0 time 0 Range of type 2 is 4,5 author 0 time 0 It should be type 1 over 0,3 and type 2 over 3,4. So the deleted "a" is=20 marked, but it's at position 4 in the change table_, while the actual "a" i= s=20 at position 3. JB =2D-=20 Johnathan K. Burchill, Ph.D. jkerrb@users.sourceforge.net --nextPart1881236.QJ8fUCtnWW Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQBCGgfxrXMSOtiWrO4RAqCyAKC5d1731qASCurWgFzhb2lIbxwajgCgzGbM AyOX1r6K5N8pUH6fJ3W6XXY= =Ngt+ -----END PGP SIGNATURE----- --nextPart1881236.QJ8fUCtnWW--