[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ltp-list
Subject:    Re: [LTP]
From:       Jiri Palecek <jpalecek () web ! de>
Date:       2009-06-08 11:02:32
Message-ID: 200906081302.33191.jpalecek () web ! de
[Download RAW message or body]

On Tuesday 02 June 2009 17:47:13 Cyril Hrubis wrote:
> > > I'm passing NULL to tst_brkm, so we should never enter this code.  But
> > > tst_brkm() calls tst_exit() in some circumstances so we should either add
> > > __atribute__ ((noreturn)) to tst_brkm too or remove tst_exit() from it.
> > > 
> > 
> > OK. How about we do,
> > 
> >     	tst_resm(TCONF, "libaio missing");
> > 	tst_exit();
> > 
> > instead of,
> > 
> > 	tst_brkm(TCONF, NULL, "libaio missing");
> > 	tst_exit();
> > 
> > since I can't see the reason to use tst_brkm() in this case?
> 
> Sounds reasonable for this case, but I still think we should rethink which
> tst_* functions calls exit() or tst_exit() and if they needs __attribute__
> ((noreturn)).

If you want the compiler to infer some calls don't return while others do, you can try this patch[1].

Regards
  Jiri Palecek

[1]: http://repo.or.cz/w/ltp-debian.git?a=commit;h=c66d9936983d6d936d51b44c46601ab6d8537231

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
[prev in list] [next in list] [prev in thread] [next in thread]