[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D29308: [PM] Hook the instrumented PGO machinery in the new PM
From:       David Li via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2017-01-31 23:54:32
Message-ID: e7536b602e6b57ae4298353938d79874 () localhost ! localdomain
[Download RAW message or body]

davidxl added inline comments.


================
Comment at: lib/Passes/PassBuilder.cpp:394
+    // In the old pass manager, this is a cl::opt. Should still this be one?
+    IP.DefaultThreshold = 75;
+
----------------
can you refactor the old pm code such that the existing internal options can be \
reused here?


================
Comment at: lib/Passes/PassBuilder.cpp:487
+  // Indirect call promotion that promotes intra-module targes only.
+  MPM.addPass(PGOIndirectCallPromotion());
+
----------------
this seems like exposing a bug in old implementation as well. IndirectCallPromotion \
pass need not to be run profile-use is in effect. Otherwise it is a waste of compile \
time.


https://reviews.llvm.org/D29308



_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]