[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D29354: SanitizerCoverage: Support sanitizer guard section on darwin
From:       "Kuba \(Brecka\) Mracek via Phabricator via llvm-commits" <llvm-commits () lists ! ll
Date:       2017-01-31 23:53:53
Message-ID: 3ad79d82d99d3d12be691dabe2b2f3ee () localhost ! localdomain
[Download RAW message or body]

kubamracek added a comment.

Agree with @kcc, I don't think we need the prefix abstraction macro and we can just \
have strings with the full section/symbol name.  E.g. in AddressSanitizer.cpp we \
have:

  StringRef AddressSanitizerModule::getGlobalMetadataSection() const {
    switch (TargetTriple.getObjectFormat()) {
    case Triple::COFF:  return ".ASAN$GL";
    case Triple::ELF:   return "asan_globals";
    case Triple::MachO: return "__DATA,__asan_globals,regular";
    default: break;
    }
    llvm_unreachable("unsupported object format");
  }


https://reviews.llvm.org/D29354



_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]