[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH 11/25] lpfc: Convert ring number to hardware queue for nvme wqe posting.
From:       Hannes Reinecke <hare () suse ! de>
Date:       2018-12-28 9:19:33
Message-ID: 14aec941-6df7-6cba-0532-21f20f36e0e9 () suse ! de
[Download RAW message or body]

On 12/27/18 12:33 AM, James Smart wrote:
> SLI4 nvme functions are passing the SLI3 ring number when posting
> wqe to hardware. This should be indicating the hardware queue to
> use, not the ring number.
> 
> Replace ring number with the hardware queue that should be used.
> 
> Note: SCSI avoided this issue as it utilized an older lfpc_issue_iocb
> routine that properly adapts.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
>   drivers/scsi/lpfc/lpfc_crtn.h  |  4 ++--
>   drivers/scsi/lpfc/lpfc_init.c  |  3 ++-
>   drivers/scsi/lpfc/lpfc_nvme.c  | 11 ++++++-----
>   drivers/scsi/lpfc/lpfc_nvme.h  |  3 ++-
>   drivers/scsi/lpfc/lpfc_nvmet.c | 34 ++++++++++++++++++++++++++--------
>   drivers/scsi/lpfc/lpfc_nvmet.h |  1 +
>   drivers/scsi/lpfc/lpfc_scsi.c  |  9 +++++----
>   drivers/scsi/lpfc/lpfc_scsi.h  |  3 ++-
>   drivers/scsi/lpfc/lpfc_sli.c   | 26 ++++++++++++++------------
>   9 files changed, 60 insertions(+), 34 deletions(-)
> 
Should actually be folded into the patch to move to shared qp, but anyway:

Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes

[prev in list] [next in list] [prev in thread] [next in thread]