[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH 10/25] lpfc: Move SCSI and NVME Stats to hardware queue structures
From:       Hannes Reinecke <hare () suse ! de>
Date:       2018-12-28 9:18:01
Message-ID: 199fa7a1-1809-9e99-4dc1-6ce9dac7d172 () suse ! de
[Download RAW message or body]

On 12/27/18 12:33 AM, James Smart wrote:
> Many io statics were being sampled and saved using adapter-based
> data structures. This was creating a lot of contention and cache
> thrashing in the I/O path.
> 
> Move the statistics to the hardware queue data structures.
> Given the per queue data structures, use of atomic types is
> lessened.
> 
> Add new syfs and debugfs stat routines to collate the per
> hardware queue values and report at an adapter level.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
>   drivers/scsi/lpfc/lpfc.h         |   9 +--
>   drivers/scsi/lpfc/lpfc_attr.c    |  68 ++++++++++++++---
>   drivers/scsi/lpfc/lpfc_debugfs.c | 158 +++++++++++++++++++++++++++++++++++++--
>   drivers/scsi/lpfc/lpfc_debugfs.h |   3 +
>   drivers/scsi/lpfc/lpfc_init.c    |  40 ++++++----
>   drivers/scsi/lpfc/lpfc_nvme.c    |  57 +++++---------
>   drivers/scsi/lpfc/lpfc_nvme.h    |  11 +--
>   drivers/scsi/lpfc/lpfc_scsi.c    |  47 ++++++++----
>   drivers/scsi/lpfc/lpfc_scsi.h    |   3 +
>   drivers/scsi/lpfc/lpfc_sli4.h    |  11 +++
>   10 files changed, 304 insertions(+), 103 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
[prev in list] [next in list] [prev in thread] [next in thread]