[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH][SCSI] cxgb3i: Fix error path for module init
From:       Mike Christie <michaelc () cs ! wisc ! edu>
Date:       2010-04-28 6:21:39
Message-ID: 4BD7D3F3.2070002 () cs ! wisc ! edu
[Download RAW message or body]

On 04/28/2010 12:39 AM, Roland Dreier wrote:
> If cxgb3i_pdu_init() fails, then it appears that cxgb3i_iscsi_init()
> will not be cleaned up, leading to the iscsi transport being left
> registered.  Fix this by adding a call to cxgb3i_iscsi_cleanup() on the
> error path.
>
> Signed-off-by: Roland Dreier<rolandd@cisco.com>
> ---
>   drivers/scsi/cxgb3i/cxgb3i_init.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/cxgb3i/cxgb3i_init.c b/drivers/scsi/cxgb3i/cxgb3i_init.c
> index d0ab23a..685af36 100644
> --- a/drivers/scsi/cxgb3i/cxgb3i_init.c
> +++ b/drivers/scsi/cxgb3i/cxgb3i_init.c
> @@ -104,8 +104,10 @@ static int __init cxgb3i_init_module(void)
>   		return err;
>
>   	err = cxgb3i_pdu_init();
> -	if (err<  0)
> +	if (err<  0) {
> +		cxgb3i_iscsi_cleanup();
>   		return err;
> +	}
>
>   	cxgb3_register_client(&t3c_client);
>
>

Looks good to me.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]