[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-omap
Subject:    Re: Patch: Init/shutdown correctness fixes for drivers/cbus/tahvo*
From:       Felipe Balbi <felipe.balbi () nokia ! com>
Date:       2009-06-11 20:36:57
Message-ID: 20090611203657.GB31172 () nokia ! com
[Download RAW message or body]

Hi,

On Thu, Jun 11, 2009 at 07:26:46PM +0200, ext Andrew de Quincey wrote:
> Hi - the current phase I'm in of this development is to simply get the  
> thing working reliably again; that includes cleanup etc as appropriate.
> 
> Once that is complete, i want to go back and refactor all the drivers  
> s that they do exactly what you suggest above, as well as using the  
> latest kernel APIs, modularisation where appropriate etc, with a view  
> to being suitable for mainline (even if they are not actually  
> submitted to mainline).
> 
> I don't want to do both at once because I feel that is too big a step  
> for this older slightly unmaintained code. Is it acceptable to you to  
> commit this patch in the interim?

That's fine then, but at least fix this line:

+	struct tahvo_usb *tu = (struct tahvo_usb*) pdev->dev.driver_data;

then you have my ack

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]