[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mips
Subject:    Re: [PATCH] IP22: Fix crashes due to wrong L1_CACHE_BYTES
From:       Ralf Baechle <ralf () linux-mips ! org>
Date:       2008-06-28 18:25:09
Message-ID: 20080628182509.GA20127 () linux-mips ! org
[Download RAW message or body]

On Fri, Jun 27, 2008 at 11:52:26PM +0200, Thomas Bogendoerfer wrote:

> The introduction of a real dma cache invalidate makes it important
> to have a correct cache line size, otherwise the kernel will gives
> out two memory segment, which might share one cache line. The R4400
> Indy/Indigo2 CPU modules are using a second level cache line size
> of 128 bytes, so MIPS_L1_CACHE_SHIFT needs to be bumped up to 7 for
> IP22.

Thanks, applied.

I also think this missconfiguration is worth an additional runtime
check; the consequence of that kind of bug are subtle and painful to
debug.

  Ralf

[prev in list] [next in list] [prev in thread] [next in thread]