[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-crypto-vger
Subject:    Re: [PATCH] crypto:ccp - Return from init on allocation failure
From:       Gary R Hook <ghook () amd ! com>
Date:       2019-07-31 16:58:38
Message-ID: eed04b52-6149-0654-96ca-682c26b808e8 () amd ! com
[Download RAW message or body]

On 7/30/19 1:28 PM, Hook, Gary wrote:
> Return and fail driver initialization if a DMA pool can't be
> allocated.
> 
> Fixes: 4b394a232df7 ("crypto: ccp - Let a v5 CCP provide the same function as v3")
> 
> Signed-off-by: Gary R Hook <gary.hook@amd.com>
> ---
>   drivers/crypto/ccp/ccp-dev-v5.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v5.c
> index f146b51a23a5..3c0f0d0c3153 100644
> --- a/drivers/crypto/ccp/ccp-dev-v5.c
> +++ b/drivers/crypto/ccp/ccp-dev-v5.c
> @@ -803,6 +803,7 @@ static int ccp5_init(struct ccp_device *ccp)
>   		if (!dma_pool) {
>   			dev_err(dev, "unable to allocate dma pool\n");
>   			ret = -ENOMEM;
> +			goto e_pool;
>   		}
>   
>   		cmd_q = &ccp->cmd_q[ccp->cmd_q_count];
> 

NAK this, please ignore. I changed the subject in the v2 post; apologies 
for that.

[prev in list] [next in list] [prev in thread] [next in thread]