[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bcache
Subject:    Re: [PATCH 2/2] fix potential memory leak in function "register_bcache"
From:       Junhui Tang <tang.junhui.linux () gmail ! com>
Date:       2018-08-25 8:45:54
Message-ID: CA+NNRhGj+dXQo26BZGy=_CvsFkkjDQsjHcuqq+jv=X=rLkL=6Q () mail ! gmail ! com
[Download RAW message or body]

> if register_cache get error, memory pointed by ca should be released.
> and also, blkdev_put should be called I think.

No!  if register_cache fail, kobject_put(&ca->kobj) will be called, and memory
will be released in bch_cache_release().
Also for the next patch:
"fix some potential memory leak in bcache_device_init"
Please check again.

This email also means I am back, with this new email address.
[prev in list] [next in list] [prev in thread] [next in thread]