[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: fuzzy-matching in quickopen...
From: Dominik Haumann <dhaumann () kde ! org>
Date: 2022-09-17 19:51:51
Message-ID: CALi_srD=a8mVV-V4x9SeVwPiDoQRtYx-dSfRjkjRDOiH3zpZYA () mail ! gmail ! com
[Download RAW message or body]
Hi everyone,
I'm currently not depending on this behavior, but I perfectly understand
Alex' concern here (and he is correct with the history of quick open).
Would an option to give already opened files more weight solve this? If so,
then we could have both.
Best regards
Dominik
Alexander Neundorf <neundorf@kde.org> schrieb am Sa., 17. Sep. 2022, 11:32:
> On Freitag, 16. September 2022 22:33:36 CEST Waqar Ahmed wrote:
>
> > > Are you sure this is a better behaviour ?
>
> >
>
> > It doesn't matter. With a single letter one cannot really get very far
> and
>
> > can't really do much scoring. So I wouldn't waste time on thinking about
>
> > the single typed letter case.
>
> >
>
> > > which ? I thought that's what quickopen is for, really. At least it was
>
> >
>
> > until
>
> > a year ago.
>
> >
>
> > No, that is not what it is for. If it were, it wouldn't even list other
>
> > files at all. Quickopen is for opening files in your project + any
> already
>
> > open files (which may or may not be in the project)
>
> >
>
> > And quickopen is two years old by now. It was already there when you were
>
> > making those search/replace patches.
>
> quickopen is much older than that (see e.g.
> https://github.com/KDE/kate/blob/21f6e144ac9b11003fec518d2f502548f33fd4b1/kate/katequickopen.cpp ),
> and there the comments say "... get all open documents", later on "insert
> all project files, if any project around", so that was more an added bonus.
>
> > Tab switcher / documents plugin deal with already open files.
>
> What's the tab switcher ? Maybe that's a feature I'm not aware of.
>
> The documents side panel is not quick to use, I have to use the mouse, I
> have to search manually.
>
> > You can try increasing the score of already open files. Maybe it will
> make
>
> > it better, maybe not. Right now only one point is added, which is
> probably
>
> > too low. Maybe there is a better way to add this score so that files that
>
> > are a good match + open are ranked better.
>
> Is there a unit test or example for the fuzzy matching somewhere already ?
>
> Thanks
>
> Alex
>
>
[Attachment #3 (text/html)]
<div dir="auto">Hi everyone,<div dir="auto"><br></div><div dir="auto">I'm \
currently not depending on this behavior, but I perfectly understand Alex' \
concern here (and he is correct with the history of quick open). Would an option to \
give already opened files more weight solve this? If so, then we could have \
both.</div><div dir="auto"><br></div><div dir="auto">Best regards</div><div \
dir="auto">Dominik </div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">Alexander Neundorf <<a \
href="mailto:neundorf@kde.org">neundorf@kde.org</a>> schrieb am Sa., 17. Sep. \
2022, 11:32:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">On Freitag, \
16. September 2022 22:33:36 CEST Waqar Ahmed wrote:</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > Are you \
sure this is a better behaviour ?</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> It doesn't \
matter. With a single letter one cannot really get very far and</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> can't \
really do much scoring. So I wouldn't waste time on thinking about</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> the single \
typed letter case.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > which ? I \
thought that's what quickopen is for, really. At least it was</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> until</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> a year \
ago.</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> \
</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> No, \
that is not what it is for. If it were, it wouldn't even list other</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> files at all. \
Quickopen is for opening files in your project + any already</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> open files \
(which may or may not be in the project)</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> And quickopen \
is two years old by now. It was already there when you were</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> making those \
search/replace patches.</p> <br><p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">quickopen is much \
older than that (see e.g. <a \
href="https://github.com/KDE/kate/blob/21f6e144ac9b11003fec518d2f502548f33fd4b1/kate/katequickopen.cpp" \
target="_blank" rel="noreferrer">https://github.com/KDE/kate/blob/21f6e144ac9b11003fec518d2f502548f33fd4b1/kate/katequickopen.cpp</a> \
), and there the comments say "... get all open documents", later on \
"insert all project files, if any project around", so that was more an \
added bonus.</p> <br><p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> Tab switcher / \
documents plugin deal with already open files.</p> <br><p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">What's the tab \
switcher ? Maybe that's a feature I'm not aware of.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">The documents side \
panel is not quick to use, I have to use the mouse, I have to search manually.</p> \
<br><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> You can \
try increasing the score of already open files. Maybe it will make</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> it better, \
maybe not. Right now only one point is added, which is probably</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> too low. Maybe \
there is a better way to add this score so that files that</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> are a good \
match + open are ranked better.</p> <br><p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">Is there a unit \
test or example for the fuzzy matching somewhere already ?</p> <br><p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">Thanks</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">Alex</p> <br></div>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic