From kwrite-devel Sat Sep 17 19:51:51 2022 From: Dominik Haumann Date: Sat, 17 Sep 2022 19:51:51 +0000 To: kwrite-devel Subject: Re: fuzzy-matching in quickopen... Message-Id: X-MARC-Message: https://marc.info/?l=kwrite-devel&m=166344403212712 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--0000000000000c33ff05e8e4d017" --0000000000000c33ff05e8e4d017 Content-Type: text/plain; charset="UTF-8" Hi everyone, I'm currently not depending on this behavior, but I perfectly understand Alex' concern here (and he is correct with the history of quick open). Would an option to give already opened files more weight solve this? If so, then we could have both. Best regards Dominik Alexander Neundorf schrieb am Sa., 17. Sep. 2022, 11:32: > On Freitag, 16. September 2022 22:33:36 CEST Waqar Ahmed wrote: > > > > Are you sure this is a better behaviour ? > > > > > > It doesn't matter. With a single letter one cannot really get very far > and > > > can't really do much scoring. So I wouldn't waste time on thinking about > > > the single typed letter case. > > > > > > > which ? I thought that's what quickopen is for, really. At least it was > > > > > > until > > > a year ago. > > > > > > No, that is not what it is for. If it were, it wouldn't even list other > > > files at all. Quickopen is for opening files in your project + any > already > > > open files (which may or may not be in the project) > > > > > > And quickopen is two years old by now. It was already there when you were > > > making those search/replace patches. > > quickopen is much older than that (see e.g. > https://github.com/KDE/kate/blob/21f6e144ac9b11003fec518d2f502548f33fd4b1/kate/katequickopen.cpp ), > and there the comments say "... get all open documents", later on "insert > all project files, if any project around", so that was more an added bonus. > > > Tab switcher / documents plugin deal with already open files. > > What's the tab switcher ? Maybe that's a feature I'm not aware of. > > The documents side panel is not quick to use, I have to use the mouse, I > have to search manually. > > > You can try increasing the score of already open files. Maybe it will > make > > > it better, maybe not. Right now only one point is added, which is > probably > > > too low. Maybe there is a better way to add this score so that files that > > > are a good match + open are ranked better. > > Is there a unit test or example for the fuzzy matching somewhere already ? > > Thanks > > Alex > > --0000000000000c33ff05e8e4d017 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi everyone,

I'm currently not depending on this behavior, but I perfectly understa= nd Alex' concern here (and he is correct with the history of quick open= ). Would an option to give already opened files more weight solve this? If = so, then we could have both.

Best regards
Dominik=C2=A0

Alexander Neund= orf <neundorf@kde.org> schrie= b am Sa., 17. Sep. 2022, 11:32:

On Freitag, 16. September 2022 22:33:36 CEST Waqar Ahmed wrote:

>= > Are you sure this is a better behaviour ?

>=

>= It doesn't matter. With a single letter one cannot really get very far= and

>= can't really do much scoring. So I wouldn't waste time on thinking= about

>= the single typed letter case.

>=

>= > which ? I thought that's what quickopen is for, really. At least = it was

>=

>= until

>= a year ago.

>=

>= No, that is not what it is for. If it were, it wouldn't even list othe= r

>= files at all. Quickopen is for opening files in your project + any already=

>= open files (which may or may not be in the project)

>=

>= And quickopen is two years old by now. It was already there when you were<= /p>

>= making those search/replace patches.


= quickopen is much older than that (see e.g. https://github.com/KDE/kate/blob/21= f6e144ac9b11003fec518d2f502548f33fd4b1/kate/katequickopen.cpp=C2=A0), a= nd there the comments say "... get all open documents", later on = "insert all project files, if any project around", so that was mo= re an added bonus.


= > Tab switcher / documents plugin deal with already open files.


= What's the tab switcher ? Maybe that's a feature I'm not aware = of.

The = documents side panel is not quick to use, I have to use the mouse, I have t= o search manually.


= > You can try increasing the score of already open files. Maybe it will = make

>= it better, maybe not. Right now only one point is added, which is probably=

>= too low. Maybe there is a better way to add this score so that files that<= /p>

>= are a good match + open are ranked better.


= Is there a unit test or example for the fuzzy matching somewhere already ?<= /p>

= Thanks

Alex=


--0000000000000c33ff05e8e4d017--