[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: guiFactory() in KTextEditor::MainWindow
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2020-01-17 7:11:38
Message-ID: CALi_srCMS9_zXbT8H5zp+mnq4hGDQcPC8jKZz2=ozx1xfSiBzA () mail ! gmail ! com
[Download RAW message or body]

You should add an item to the KF6 workboard:
https://phabricator.kde.org/tag/kf6/

Best regards Dominik

Christoph Cullmann <christoph@cullmann.io> schrieb am Do., 16. Jan. 2020,
20:27:

> On 2020-01-16 17:44, Thomas Friedrichsmeier wrote:
> > On Mon, 06 Jan 2020 19:50:17 +0100
> > Christoph Cullmann <christoph@cullmann.io> wrote:
> >> For the proposed extension/change: Perhaps we should do it the other
> >> way around:
> >>
> >> 1) Deprecate KTextEditor::MainWindow::guiFactory()
> >> 2) Let the host application add the plugin views to it's GUI by
> >> "requiring" that they
> >> inherit from the KXMLGUIClient
> >
> > Well, that wasn't quite as easy as expected, formally, as KXMLGUIClient
> > is not derived from QObject.
>
> Hmm, we could extend it to have some Q_DECLARE_INTERFACE declared, then
> you can
> cast it with qobject_cast.
>
> On the other side, even dynamic_cast should be no issue, given I doubt
> we compile anywere without RTTI.
>
> >
> > Anyway, a proposal along those lines is now in a side-branch of the
> > ktexteditor and kate repositories (and it appears to be functional,
> > too). I hope that is an appropriate place.
>
> Sure, that is very nice, we don't loose your work that way that easily
> ;=)
>
> Greetings
> Christoph
>
> >
> > Regards
> > Thomas
>
> --
> Ignorance is bliss...
> https://cullmann.io | https://kate-editor.org
>

[Attachment #3 (text/html)]

<div dir="auto">You should add an item to the KF6 workboard:  <a \
href="https://phabricator.kde.org/tag/kf6/">https://phabricator.kde.org/tag/kf6/</a><div \
dir="auto"><br></div><div dir="auto">Best regards Dominik</div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">Christoph Cullmann &lt;<a \
href="mailto:christoph@cullmann.io">christoph@cullmann.io</a>&gt; schrieb am Do., 16. \
Jan. 2020, 20:27:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">On 2020-01-16 17:44, Thomas \
Friedrichsmeier wrote:<br> &gt; On Mon, 06 Jan 2020 19:50:17 +0100<br>
&gt; Christoph Cullmann &lt;<a href="mailto:christoph@cullmann.io" target="_blank" \
rel="noreferrer">christoph@cullmann.io</a>&gt; wrote:<br> &gt;&gt; For the proposed \
extension/change: Perhaps we should do it the other<br> &gt;&gt; way around:<br>
&gt;&gt; <br>
&gt;&gt; 1) Deprecate KTextEditor::MainWindow::guiFactory()<br>
&gt;&gt; 2) Let the host application add the plugin views to it&#39;s GUI by<br>
&gt;&gt; &quot;requiring&quot; that they<br>
&gt;&gt; inherit from the KXMLGUIClient<br>
&gt; <br>
&gt; Well, that wasn&#39;t quite as easy as expected, formally, as KXMLGUIClient<br>
&gt; is not derived from QObject.<br>
<br>
Hmm, we could extend it to have some Q_DECLARE_INTERFACE declared, then <br>
you can<br>
cast it with qobject_cast.<br>
<br>
On the other side, even dynamic_cast should be no issue, given I doubt<br>
we compile anywere without RTTI.<br>
<br>
&gt; <br>
&gt; Anyway, a proposal along those lines is now in a side-branch of the<br>
&gt; ktexteditor and kate repositories (and it appears to be functional,<br>
&gt; too). I hope that is an appropriate place.<br>
<br>
Sure, that is very nice, we don&#39;t loose your work that way that easily <br>
;=)<br>
<br>
Greetings<br>
Christoph<br>
<br>
&gt; <br>
&gt; Regards<br>
&gt; Thomas<br>
<br>
-- <br>
Ignorance is bliss...<br>
<a href="https://cullmann.io" rel="noreferrer noreferrer" \
target="_blank">https://cullmann.io</a> | <a href="https://kate-editor.org" \
rel="noreferrer noreferrer" target="_blank">https://kate-editor.org</a><br> \
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]