From kwrite-devel Fri Jan 17 07:11:38 2020 From: Dominik Haumann Date: Fri, 17 Jan 2020 07:11:38 +0000 To: kwrite-devel Subject: Re: guiFactory() in KTextEditor::MainWindow Message-Id: X-MARC-Message: https://marc.info/?l=kwrite-devel&m=157924512401775 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--000000000000b7279f059c50a7fd" --000000000000b7279f059c50a7fd Content-Type: text/plain; charset="UTF-8" You should add an item to the KF6 workboard: https://phabricator.kde.org/tag/kf6/ Best regards Dominik Christoph Cullmann schrieb am Do., 16. Jan. 2020, 20:27: > On 2020-01-16 17:44, Thomas Friedrichsmeier wrote: > > On Mon, 06 Jan 2020 19:50:17 +0100 > > Christoph Cullmann wrote: > >> For the proposed extension/change: Perhaps we should do it the other > >> way around: > >> > >> 1) Deprecate KTextEditor::MainWindow::guiFactory() > >> 2) Let the host application add the plugin views to it's GUI by > >> "requiring" that they > >> inherit from the KXMLGUIClient > > > > Well, that wasn't quite as easy as expected, formally, as KXMLGUIClient > > is not derived from QObject. > > Hmm, we could extend it to have some Q_DECLARE_INTERFACE declared, then > you can > cast it with qobject_cast. > > On the other side, even dynamic_cast should be no issue, given I doubt > we compile anywere without RTTI. > > > > > Anyway, a proposal along those lines is now in a side-branch of the > > ktexteditor and kate repositories (and it appears to be functional, > > too). I hope that is an appropriate place. > > Sure, that is very nice, we don't loose your work that way that easily > ;=) > > Greetings > Christoph > > > > > Regards > > Thomas > > -- > Ignorance is bliss... > https://cullmann.io | https://kate-editor.org > --000000000000b7279f059c50a7fd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
You should add an item to the KF6 workboard:=C2=A0https://phabricator.kde.org/tag/k= f6/

Best regards Dominik

Christoph Cullmann <christo= ph@cullmann.io> schrieb am Do., 16. Jan. 2020, 20:27:
On 2020-01-16 17:44, Thomas Friedrichsmeier wrote= :
> On Mon, 06 Jan 2020 19:50:17 +0100
> Christoph Cullmann <christoph@cullmann.io> wrote:
>> For the proposed extension/change: Perhaps we should do it the oth= er
>> way around:
>>
>> 1) Deprecate KTextEditor::MainWindow::guiFactory()
>> 2) Let the host application add the plugin views to it's GUI b= y
>> "requiring" that they
>> inherit from the KXMLGUIClient
>
> Well, that wasn't quite as easy as expected, formally, as KXMLGUIC= lient
> is not derived from QObject.

Hmm, we could extend it to have some Q_DECLARE_INTERFACE declared, then you can
cast it with qobject_cast.

On the other side, even dynamic_cast should be no issue, given I doubt
we compile anywere without RTTI.

>
> Anyway, a proposal along those lines is now in a side-branch of the > ktexteditor and kate repositories (and it appears to be functional, > too). I hope that is an appropriate place.

Sure, that is very nice, we don't loose your work that way that easily =
;=3D)

Greetings
Christoph

>
> Regards
> Thomas

--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org
--000000000000b7279f059c50a7fd--