[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: KATE: Unable to use LSP server for PHP
From: Dominik Haumann <dhaumann () kde ! org>
Date: 2019-12-30 19:55:55
Message-ID: CALi_srDP1LZt5DpkZqPudXp3VHJSjc3tUS8Z=bex125dSi9deg () mail ! gmail ! com
[Download RAW message or body]
I am in favour along with a blog post that mentions this change starting
with 19.12.1.
Best regards
Dominik
Christoph Cullmann <christoph@cullmann.io> schrieb am Mo., 30. Dez. 2019,
20:51:
> Hi,
>
> I would like to backport the change with the highlightingModeRegex to
> 19.12, without the docu changes.
>
> I think that will make the plugin easier to extend for people using the
> release without any real
> drawback.
>
> Would that be ok?
>
> Greetings
> Christoph
>
> On 2019-12-28 21:23, Christoph Cullmann wrote:
> > On 2019-12-28 21:21, Dominik Haumann wrote:
> >> Hi Christoph,
> >>
> >> this is certainly the correct fix. Could you update the docs as well:
> >>
> https://docs.kde.org/trunk5/en/applications/kate/kate-application-plugin-lspclient.html
> >>
> >> Thanks :-)
> >>
> > Already done :P
> >
> > But I am not good at that, perhaps somebody can improve my changes
> > there.
> >
> > Greetings
> > Christoph
> >
> >> Best regards
> >> Dominik
> >>
> >> Christoph Cullmann <christoph@cullmann.io> schrieb am Sa., 28. Dez.
> >> 2019, 21:09:
> >>
> >>> Hi,
> >>>
> >>>>> {
> >>>>> "servers": {
> >>>>> "php": {
> >>>>> "command": ["php",
> >>>>> "/home/stolz/php-language-server/bin/php-language-server.php"],
> >>>>> "url":
> >>> "https://github.com/felixfbecker/php-language-server"
> >>>>> }
> >>>>> }
> >>>>> }
> >>>
> >>> I now pushed a change to make the mapping of highlighting mode to
> >>> language id
> >>> fully configurable in the JSON file.
> >>>
> >>> This avoids that one needs to use a patched version of Kate for
> >>> adding
> >>> new languages
> >>> that have not by chance a 1:1 mapping of id to highlighting name.
> >>>
> >>> See commit:
> >>>
> >>>
> >>
> https://invent.kde.org/kde/kate/commit/1b245783435341f10a67e3666fe24fbf89f1d384
> >>>
> >>> Greetings
> >>> Christoph
> >>>
> >>> --
> >>> Ignorance is bliss...
> >>> https://cullmann.io | https://kate-editor.org
>
> --
> Ignorance is bliss...
> https://cullmann.io | https://kate-editor.org
>
[Attachment #3 (text/html)]
<div dir="auto">I am in favour along with a blog post that mentions this change \
starting with 19.12.1.<div dir="auto"><br></div><div dir="auto">Best \
regards</div><div dir="auto">Dominik</div></div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">Christoph Cullmann <<a \
href="mailto:christoph@cullmann.io">christoph@cullmann.io</a>> schrieb am Mo., 30. \
Dez. 2019, 20:51:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br> <br>
I would like to backport the change with the highlightingModeRegex to <br>
19.12, without the docu changes.<br>
<br>
I think that will make the plugin easier to extend for people using the <br>
release without any real<br>
drawback.<br>
<br>
Would that be ok?<br>
<br>
Greetings<br>
Christoph<br>
<br>
On 2019-12-28 21:23, Christoph Cullmann wrote:<br>
> On 2019-12-28 21:21, Dominik Haumann wrote:<br>
>> Hi Christoph,<br>
>> <br>
>> this is certainly the correct fix. Could you update the docs as well:<br>
>> <a href="https://docs.kde.org/trunk5/en/applications/kate/kate-application-plugin-lspclient.html" \
rel="noreferrer noreferrer" \
target="_blank">https://docs.kde.org/trunk5/en/applications/kate/kate-application-plugin-lspclient.html</a><br>
>> <br>
>> Thanks :-)<br>
>> <br>
> Already done :P<br>
> <br>
> But I am not good at that, perhaps somebody can improve my changes <br>
> there.<br>
> <br>
> Greetings<br>
> Christoph<br>
> <br>
>> Best regards<br>
>> Dominik<br>
>> <br>
>> Christoph Cullmann <<a href="mailto:christoph@cullmann.io" \
target="_blank" rel="noreferrer">christoph@cullmann.io</a>> schrieb am Sa., 28. \
Dez.<br> >> 2019, 21:09:<br>
>> <br>
>>> Hi,<br>
>>> <br>
>>>>> {<br>
>>>>> "servers": {<br>
>>>>> "php": {<br>
>>>>> "command": ["php",<br>
>>>>> \
"/home/stolz/php-language-server/bin/php-language-server.php"],<br> \
>>>>> "url":<br> >>> "<a \
href="https://github.com/felixfbecker/php-language-server" rel="noreferrer \
noreferrer" target="_blank">https://github.com/felixfbecker/php-language-server</a>"<br>
>>>>> }<br>
>>>>> }<br>
>>>>> }<br>
>>> <br>
>>> I now pushed a change to make the mapping of highlighting mode to<br>
>>> language id<br>
>>> fully configurable in the JSON file.<br>
>>> <br>
>>> This avoids that one needs to use a patched version of Kate for<br>
>>> adding<br>
>>> new languages<br>
>>> that have not by chance a 1:1 mapping of id to highlighting name.<br>
>>> <br>
>>> See commit:<br>
>>> <br>
>>> <br>
>> <a href="https://invent.kde.org/kde/kate/commit/1b245783435341f10a67e3666fe24fbf89f1d384" \
rel="noreferrer noreferrer" \
target="_blank">https://invent.kde.org/kde/kate/commit/1b245783435341f10a67e3666fe24fbf89f1d384</a><br>
>>> <br>
>>> Greetings<br>
>>> Christoph<br>
>>> <br>
>>> --<br>
>>> Ignorance is bliss...<br>
>>> <a href="https://cullmann.io" rel="noreferrer noreferrer" \
target="_blank">https://cullmann.io</a> | <a href="https://kate-editor.org" \
rel="noreferrer noreferrer" target="_blank">https://kate-editor.org</a><br> <br>
-- <br>
Ignorance is bliss...<br>
<a href="https://cullmann.io" rel="noreferrer noreferrer" \
target="_blank">https://cullmann.io</a> | <a href="https://kate-editor.org" \
rel="noreferrer noreferrer" target="_blank">https://kate-editor.org</a><br> \
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic