--000000000000081b9c059af13cb0 Content-Type: text/plain; charset="UTF-8" I am in favour along with a blog post that mentions this change starting with 19.12.1. Best regards Dominik Christoph Cullmann schrieb am Mo., 30. Dez. 2019, 20:51: > Hi, > > I would like to backport the change with the highlightingModeRegex to > 19.12, without the docu changes. > > I think that will make the plugin easier to extend for people using the > release without any real > drawback. > > Would that be ok? > > Greetings > Christoph > > On 2019-12-28 21:23, Christoph Cullmann wrote: > > On 2019-12-28 21:21, Dominik Haumann wrote: > >> Hi Christoph, > >> > >> this is certainly the correct fix. Could you update the docs as well: > >> > https://docs.kde.org/trunk5/en/applications/kate/kate-application-plugin-lspclient.html > >> > >> Thanks :-) > >> > > Already done :P > > > > But I am not good at that, perhaps somebody can improve my changes > > there. > > > > Greetings > > Christoph > > > >> Best regards > >> Dominik > >> > >> Christoph Cullmann schrieb am Sa., 28. Dez. > >> 2019, 21:09: > >> > >>> Hi, > >>> > >>>>> { > >>>>> "servers": { > >>>>> "php": { > >>>>> "command": ["php", > >>>>> "/home/stolz/php-language-server/bin/php-language-server.php"], > >>>>> "url": > >>> "https://github.com/felixfbecker/php-language-server" > >>>>> } > >>>>> } > >>>>> } > >>> > >>> I now pushed a change to make the mapping of highlighting mode to > >>> language id > >>> fully configurable in the JSON file. > >>> > >>> This avoids that one needs to use a patched version of Kate for > >>> adding > >>> new languages > >>> that have not by chance a 1:1 mapping of id to highlighting name. > >>> > >>> See commit: > >>> > >>> > >> > https://invent.kde.org/kde/kate/commit/1b245783435341f10a67e3666fe24fbf89f1d384 > >>> > >>> Greetings > >>> Christoph > >>> > >>> -- > >>> Ignorance is bliss... > >>> https://cullmann.io | https://kate-editor.org > > -- > Ignorance is bliss... > https://cullmann.io | https://kate-editor.org > --000000000000081b9c059af13cb0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

I am in favour along with a blog post that mentions this = change starting with 19.12.1.

= Best regards

Dominik

Christoph Cullmann <christoph@cullmann.io> schrieb= am Mo., 30. Dez. 2019, 20:51:

Hi,<= br>
I would like to backport the change with the highlightingModeRegex to
19.12, without the docu changes.

I think that will make the plugin easier to extend for people using the release without any real
drawback.

Would that be ok?

Greetings
Christoph

On 2019-12-28 21:23, Christoph Cullmann wrote:
> On 2019-12-28 21:21, Dominik Haumann wrote:
>> Hi Christoph,
>>
>> this is certainly the correct fix. Could you update the docs as we= ll:
>> https://docs.kde.org/trunk5/en/applications/kate/kate-application-pl= ugin-lspclient.html
>>
>> Thanks :-)
>>
> Already done :P
>
> But I am not good at that, perhaps somebody can improve my changes > there.
>
> Greetings
> Christoph
>
>> Best regards
>> Dominik
>>
>> Christoph Cullmann <christoph@cullmann.io> schrieb am= Sa., 28. Dez.
>> 2019, 21:09:
>>
>>> Hi,
>>>
>>>>> {
>>>>> "servers": {
>>>>> "php": {
>>>>> "command": ["php",
>>>>> "/home/stolz/php-language-server/bin/php-language= -server.php"],
>>>>> "url":
>>> "https://github.com/= felixfbecker/php-language-server"
>>>>> }
>>>>> }
>>>>> }
>>>
>>> I now pushed a change to make the mapping of highlighting mode= to
>>> language id
>>> fully configurable in the JSON file.
>>>
>>> This avoids that one needs to use a patched version of Kate fo= r
>>> adding
>>> new languages
>>> that have not by chance a 1:1 mapping of id to highlighting na= me.
>>>
>>> See commit:
>>>
>>>
>> h= ttps://invent.kde.org/kde/kate/commit/1b245783435341f10a67e3666fe24fbf89f1d= 384
>>>
>>> Greetings
>>> Christoph
>>>
>>> --
>>> Ignorance is bliss...
>>> https://cullmann.io | https://kate-editor.or= g

--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org

--000000000000081b9c059af13cb0--