[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 129550: python syntax: added f-literals and improved string handling
From: "Philipp A." <flying-sheep () web ! de>
Date: 2016-12-10 14:24:38
Message-ID: 20161210142438.13487.42429 () mimi ! kde ! org
[Download RAW message or body]
--===============1961480226973791725==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 10, 2016, 2:03 p.m., Sven Brauch wrote:
> > LGTM in general, didn't review every detail though. Let's submit it and wait for \
> > complaints, if any?
cool, thanks!
- Philipp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129550/#review101355
-----------------------------------------------------------
On Dec. 10, 2016, 2:24 p.m., Philipp A. wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129550/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2016, 2:24 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: syntax-highlighting
>
>
> Description
> -------
>
> python syntax: added f-literals and improved string handling
>
>
> Diffs
> -----
>
> autotests/folding/test.py.fold ae0b98a0a14d2fc81f2628a5e1a13db0936106df
> autotests/html/test.py.html ad953cd115a10f0bd12249dd56efd8afc5fdf6d9
> autotests/input/test.py 3c0392c1838273af168eec64f346afe02e8d79e9
> autotests/reference/test.py.ref bb85ce0c2956da0638252fbe08e985d06221036f
> data/syntax/python.xml 670e22a9add3af0458a81a2fde2af7247fc45d65
>
> Diff: https://git.reviewboard.kde.org/r/129550/diff/
>
>
> Testing
> -------
>
> added running tests for the feature, no lines of the existing output changed.
>
>
> Thanks,
>
> Philipp A.
>
>
--===============1961480226973791725==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129550/">https://git.reviewboard.kde.org/r/129550/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 10th, 2016, 2:03 p.m. UTC, <b>Sven \
Brauch</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">LGTM in general, didn't review every detail though. \
Let's submit it and wait for complaints, if any?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">cool, \
thanks!</p></pre> <br />
<p>- Philipp</p>
<br />
<p>On December 10th, 2016, 2:24 p.m. UTC, Philipp A. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Philipp A..</div>
<p style="color: grey;"><i>Updated Dec. 10, 2016, 2:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
syntax-highlighting
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">python syntax: added f-literals and improved string handling</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">added running tests for the feature, no lines of the \
existing output changed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/folding/test.py.fold <span style="color: \
grey">(ae0b98a0a14d2fc81f2628a5e1a13db0936106df)</span></li>
<li>autotests/html/test.py.html <span style="color: \
grey">(ad953cd115a10f0bd12249dd56efd8afc5fdf6d9)</span></li>
<li>autotests/input/test.py <span style="color: \
grey">(3c0392c1838273af168eec64f346afe02e8d79e9)</span></li>
<li>autotests/reference/test.py.ref <span style="color: \
grey">(bb85ce0c2956da0638252fbe08e985d06221036f)</span></li>
<li>data/syntax/python.xml <span style="color: \
grey">(670e22a9add3af0458a81a2fde2af7247fc45d65)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129550/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1961480226973791725==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic