[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: KTextEditor::SearchInterface
From:       Christoph Cullmann <cullmann () absint ! com>
Date:       2015-04-02 21:10:29
Message-ID: 595182360.87624.1428009029591.JavaMail.zimbra () absint ! com
[Download RAW message or body]

> Hi Christoph,
> 
> On Saturday 28 March 2015 10:06:06 Christoph Cullmann wrote:
> > Hi,
> > 
> > I have nothing against a search interface implementation inside the
> > KTextEditor framework.
> > 
> > Come up with a nice interface for it and we can decide if we want to merge
> > it ;=)
> 
> could you have a look a the current search interface we have in KatePart
> internally? It would do, and is already implemented. Are there arguments
> against just using this?
Hmmm,

I think its not that bad, but I am not sure if we don't need to cleanup it first
before we expose it for the complete 5.x series ;)

Greetings & Happy Easter :P

Christoph


> 
> Greetings,
> Dominik
> 
> > ----- Ursprüngliche Mail -----
> > > On Sunday 01 March 2015 10:42:36 Sven Brauch wrote:
> > > > On 01/03/15 10:33, Andreas Cord-Landwehr wrote:
> > > > > It's at [1] at line 790ff.
> > > > 
> > > > It looks like you could simply replace it by a QString::indexOf call,
> > > > maybe?
> > > 
> > > Hi, after some further code digging I found a couple of other places [1]
> > > where
> > > the search interface is used (using options RegEx, CaseInsensitive, or
> > > Backwards). From my current point of view (and an IRC discussion with
> > > Sven),
> > > working around the missing search-interface is possible by simply using
> > > indexOf, QRegExp and adding all the boilderplate code to work with Range
> > > and
> > > Curser elements from KTextEditor.
> > > 
> > > However, for me it looks like re-implementing something that is already
> > > there
> > > for Kate, and IMO it seems much more straight forward to simply allow a
> > > (minimalistic) search interface for KTextEditor.
> > > 
> > > I got Sven to be "undecided" about it, other opinions? :)
> > > 
> > > Cheers,
> > > Andreas
> > > 
> > > [1]
> > > http://quickgit.kde.org/?p=kile.git&a=blob&h=cb4e610f0064791585836137d92b3dd8dbfde45a&hb=c4883fa50f2666b503bb846e5a2e1a48b0f2cf5b&f=src%2Feditorextension.cpp
> > >  _______________________________________________
> > > KWrite-Devel mailing list
> > > KWrite-Devel@kde.org
> > > https://mail.kde.org/mailman/listinfo/kwrite-devel
> > > 
> > 
> > 
> 
> _______________________________________________
> KWrite-Devel mailing list
> KWrite-Devel@kde.org
> https://mail.kde.org/mailman/listinfo/kwrite-devel
> 

-- 
----------------------------- Dr.-Ing. Christoph Cullmann ---------
AbsInt Angewandte Informatik GmbH      Email: cullmann@AbsInt.com
Science Park 1                         Tel:   +49-681-38360-22
66123 Saarbrücken                      Fax:   +49-681-38360-20
GERMANY                                WWW:   http://www.AbsInt.com
--------------------------------------------------------------------
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]