'Re: Review Request 120189: Adding support for repeating actions in replace mode'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 120189: Adding support for repeating actions in replace mode
From:       Miquel_SabatĂŠ_SolĂ  <mikisabate () gmail ! com>
Date:       2014-09-14 11:14:25
Message-ID: 20140914111425.22585.65598 () probe ! kde ! org
[Download RAW message or body]

--===============0085575187888780705==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120189/#review66451
-----------------------------------------------------------

Ship it!

Ship It!

- Miquel SabatĂŠ SolĂ 

On Sept. 13, 2014, 8:23 p.m., Emeric Dupont wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120189/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 8:23 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Pressing . after performing changes in replace mode now repeats the changes.
> Pressing 2. still fails, due to wrong count handling in Replace mode. Upcoming fix
> 
> 
> Diffs
> -----
> 
> src/vimode/modes/normalvimode.cpp b47ed0aa65295b68d2999e24ed2d9d2581f5795e 
> autotests/src/vimode/modes.cpp 72bb9afd2d1bd1e00c5e9f61b5ec3e610976184d 
> 
> Diff: https://git.reviewboard.kde.org/r/120189/diff/
> 
> 
> Testing
> -------
> 
> See unit tests.
> 
> 
> Thanks,
> 
> Emeric Dupont
> 
> 

--===============0085575187888780705==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120189/">https://git.reviewboard.kde.org/r/120189/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />

<p>- Miquel SabatĂŠ SolĂ </p>

<br />
<p>On September 13th, 2014, 8:23 p.m. UTC, Emeric Dupont wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Emeric Dupont.</div>

<p style="color: grey;"><i>Updated Sept. 13, 2014, 8:23 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Pressing . after performing changes in replace mode \
now repeats the changes.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> Pressing 2. still fails, due to wrong \
count handling in Replace mode. Upcoming fix</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See unit tests.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/vimode/modes/normalvimode.cpp <span style="color: \
grey">(b47ed0aa65295b68d2999e24ed2d9d2581f5795e)</span></li>

 <li>autotests/src/vimode/modes.cpp <span style="color: \
grey">(72bb9afd2d1bd1e00c5e9f61b5ec3e610976184d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120189/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0085575187888780705==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 