'Re: Review Request 119047: vi-mode: refactor jump list'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 119047: vi-mode: refactor jump list
From:       "Michal Humpula" <michal.humpula () hudrydum ! cz>
Date:       2014-06-30 20:09:06
Message-ID: 20140630200906.17520.58155 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119047/
-----------------------------------------------------------

(Updated June 30, 2014, 8:09 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate and Miquel SabatĂŠ SolĂ .

Repository: ktexteditor

Description
-------

Since the Marks refactor was such a success I decided to give myself another present \
today and refaktor jumps. The idea is the same.

During the hacking I've noticed one funny thing. That there are probably no test at \
all for this functionality and as a result it's probably not functioning properly. So \
brace yourself, more tests are comming.

Diffs
-----

  src/CMakeLists.txt 44bc609 
  src/vimode/jumps.h PRE-CREATION 
  src/vimode/jumps.cpp PRE-CREATION 
  src/vimode/kateviinputmodemanager.h 64a1b6d 
  src/vimode/kateviinputmodemanager.cpp 076f5c0 
  src/vimode/katevimodebase.cpp 4ffd04b 
  src/vimode/katevinormalmode.h bdd098c 
  src/vimode/katevinormalmode.cpp e60087b 

Diff: https://git.reviewboard.kde.org/r/119047/diff/

Testing
-------

make test

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119047/">https://git.reviewboard.kde.org/r/119047/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Miquel SabatĂŠ SolĂ .</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated June 30, 2014, 8:09 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since the Marks refactor was such a success I decided to give myself \
another present today and refaktor jumps. The idea is the same.

During the hacking I&#39;ve noticed one funny thing. That there are probably no test \
at all for this functionality and as a result it&#39;s probably not functioning \
properly. So brace yourself, more tests are comming.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">make test</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(44bc609)</span></li>

 <li>src/vimode/jumps.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/vimode/jumps.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/vimode/kateviinputmodemanager.h <span style="color: \
grey">(64a1b6d)</span></li>

 <li>src/vimode/kateviinputmodemanager.cpp <span style="color: \
grey">(076f5c0)</span></li>

 <li>src/vimode/katevimodebase.cpp <span style="color: grey">(4ffd04b)</span></li>

 <li>src/vimode/katevinormalmode.h <span style="color: grey">(bdd098c)</span></li>

 <li>src/vimode/katevinormalmode.cpp <span style="color: grey">(e60087b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119047/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 