--===============5986884493884080695== Content-Type: multipart/alternative; boundary="===============7797326423764489618==" --===============7797326423764489618== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119047/ ----------------------------------------------------------- (Updated June 30, 2014, 8:09 p.m.) Status ------ This change has been marked as submitted. Review request for Kate and Miquel Sabaté Solà. Repository: ktexteditor Description ------- Since the Marks refactor was such a success I decided to give myself another present today and refaktor jumps. The idea is the same. During the hacking I've noticed one funny thing. That there are probably no test at all for this functionality and as a result it's probably not functioning properly. So brace yourself, more tests are comming. Diffs ----- src/CMakeLists.txt 44bc609 src/vimode/jumps.h PRE-CREATION src/vimode/jumps.cpp PRE-CREATION src/vimode/kateviinputmodemanager.h 64a1b6d src/vimode/kateviinputmodemanager.cpp 076f5c0 src/vimode/katevimodebase.cpp 4ffd04b src/vimode/katevinormalmode.h bdd098c src/vimode/katevinormalmode.cpp e60087b Diff: https://git.reviewboard.kde.org/r/119047/diff/ Testing ------- make test Thanks, Michal Humpula --===============7797326423764489618== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119047/

This change has been marked as submitted.

Review request for Kate and Miquel Sabaté Solà.
By Michal Humpula.

Updated June 30, 2014, 8:09 p.m.

Repository: ktexteditor

Description 

Since the Marks refactor was such a success I decided to give myself another present today and refaktor jumps. The idea is the same.

During the hacking I've noticed one funny thing. That there are probably no test at all for this functionality and as a result it's probably not functioning properly. So brace yourself, more tests are comming.

Testing 

make test

Diffs

  • src/CMakeLists.txt (44bc609)
  • src/vimode/jumps.h (PRE-CREATION)
  • src/vimode/jumps.cpp (PRE-CREATION)
  • src/vimode/kateviinputmodemanager.h (64a1b6d)
  • src/vimode/kateviinputmodemanager.cpp (076f5c0)
  • src/vimode/katevimodebase.cpp (4ffd04b)
  • src/vimode/katevinormalmode.h (bdd098c)
  • src/vimode/katevinormalmode.cpp (e60087b)

View Diff
--===============7797326423764489618==-- --===============5986884493884080695== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============5986884493884080695==--